Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple phases per challenge #1488

Merged
merged 6 commits into from
Aug 27, 2020
Merged

Allow multiple phases per challenge #1488

merged 6 commits into from
Aug 27, 2020

Conversation

jmsmkn
Copy link
Member

@jmsmkn jmsmkn commented Aug 25, 2020

This PR:

  • Breaks the 1:1 relationship between evaluation configurations and challenges
  • Renames Config to Phase
  • Links Method and Submission to Phase rather than Challenge

This PR does not allow for multiple phases per challenge yet, but is the first of 3 steps in doing so.

#738

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #1488 into master will increase coverage by 0.00%.
The diff coverage is 97.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1488   +/-   ##
=======================================
  Coverage   94.46%   94.47%           
=======================================
  Files         598      599    +1     
  Lines       22695    22715   +20     
=======================================
+ Hits        21439    21459   +20     
  Misses       1256     1256           
Impacted Files Coverage Δ
app/config/settings.py 94.28% <ø> (ø)
app/grandchallenge/challenges/tasks.py 0.00% <ø> (ø)
app/grandchallenge/datasets/models.py 96.15% <ø> (ø)
app/grandchallenge/evaluation/urls.py 100.00% <ø> (ø)
app/grandchallenge/statistics/views.py 100.00% <ø> (ø)
app/tests/core_tests/test_fixtures.py 100.00% <ø> (ø)
app/tests/factories.py 100.00% <ø> (ø)
app/grandchallenge/evaluation/views.py 79.53% <75.00%> (ø)
app/grandchallenge/evaluation/models.py 90.70% <91.66%> (+0.08%) ⬆️
...e/challenges/management/commands/copy_challenge.py 100.00% <100.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8ee52d...84c471f. Read the comment docs.

@jmsmkn jmsmkn marked this pull request as ready for review August 27, 2020 07:30
@jmsmkn jmsmkn merged commit 0d5a1d6 into master Aug 27, 2020
@jmsmkn jmsmkn deleted the 738_evaluation_phases branch August 27, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant