Skip to content
This repository has been archived by the owner on Mar 23, 2021. It is now read-only.

Migrate comit-rs to Circle CI #863

Closed
4 of 6 tasks
D4nte opened this issue Apr 10, 2019 · 7 comments · Fixed by #984
Closed
4 of 6 tasks

Migrate comit-rs to Circle CI #863

D4nte opened this issue Apr 10, 2019 · 7 comments · Fixed by #984
Assignees

Comments

@D4nte
Copy link
Contributor

D4nte commented Apr 10, 2019

Remove Travis configuration file and Make Circle CI successful build a mandatory requirement.

DoD:

  • Check Travis subscription model
  • Update mergify config
  • Remove .travis.yml file
  • Make Circle CI Successful build check mandatory to merge PR in GitHub
  • Create issue to track the testcontainer optimisation discussed below
  • Slack integration
@thomaseizinger
Copy link
Contributor

Travis cannot test on MacOS because docker is not available there.

@D4nte
Copy link
Contributor Author

D4nte commented May 7, 2019

What is blocking this ticket? :) "good first issue"?

@bonomat
Copy link
Member

bonomat commented May 8, 2019

Nothing really, I have a working version in here #942 .

@D4nte
Copy link
Contributor Author

D4nte commented May 8, 2019

I thought there was a dependency on a testcontainers change. @thomaseizinger could you create an issue to track the testcontainers change.
I suggest we keep this one in mind for the next sprint.

@thomaseizinger
Copy link
Contributor

@thomaseizinger could you create an issue to track the testcontainers change.

Done: testcontainers/testcontainers-rs#89

@bonomat
Copy link
Member

bonomat commented May 15, 2019

Even with the non-optimzed setup, CircleCI has a better performance than Travis.

I would opt for migrate over to CircleCI now and invest some time into testcontainers/testcontainers-rs#89 to get an even better performance.

@D4nte
Copy link
Contributor Author

D4nte commented May 15, 2019

Yes go for it.

@D4nte D4nte changed the title Travis is dead, long live Travis! Migrate comit-rs to Circle CI May 29, 2019
@D4nte D4nte added this to the Sprint 15 🥾⌨️ milestone May 29, 2019
@thomaseizinger thomaseizinger self-assigned this May 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants