-
Notifications
You must be signed in to change notification settings - Fork 1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎊
4ea2ab9
to
0bad960
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume @luckysori wanted to get the typesystem to verify certain properties by using GenericArray
instead of Vec
? Have you thought about how this is affected once GenericArray
is no longer used?
I assume the refactoring towards Vec
will require quite a bit more changes then just replacing GenericArray
with Vec
, starting with Vec
taking only a single type parameter :D
Edit: I see @luckysori is actually part of the commit, should be fine then :)
Hehe, I just rebased onto master now that I added CI and force pushed so that this cannot be merged by mistake. But yeah, type safety was the main reason behind using |
This PR makes use of CC @LLFourn |
c3bbeb0
to
19db237
Compare
Losing type safety in the process. Instead we check that all the vectors in the proof have the right number of elements when verifying.
19db237
to
dd53bb2
Compare
This speeds up the painfully slow compilation of the swap crate in
xmr-btc-swap.
Attempt to fix comit-network/xmr-btc-swap#31