Honda Manual Gear msg #1034
Honda Manual Gear msg #1034
Conversation
This reverts commit d3489b5.
|
@sshane This is ready. Will be used for my Integra car port PR and a Civc Type R PR i'll be opening soon. |
| @@ -50,6 +50,11 @@ BO_ 467 CRUISE_FAULT_STATUS: 8 XXX | |||
| SG_ CHECKSUM : 59|4@0+ (1,0) [0|15] "" XXX | |||
| SG_ COUNTER : 61|2@0+ (1,0) [0|3] "" XXX | |||
|
|
|||
| BO_ 477 GEARBOX_BOH: 8 XXX | |||
There was a problem hiding this comment.
Can you give this a better name?
There was a problem hiding this comment.
GEARBOX_ALT_2, perhaps? Or could do GEARBOX_ALT_A and GEARBOX_ALT_B?
There was a problem hiding this comment.
Depends on where this comes from, Toyota calls a similar message CLUTCH. This can be GEARBOX_MANUAL or GEARBOX_MT
There was a problem hiding this comment.
I don't want to do gearbox_manual or gearbox_mt as this message is also found on the CVT transmission vehicles. The GEAR_MT signal only seems to change on MT vehicles while it's always 0 on CVT transmission vehicles. I will go with ALT_2 in order to prevent additional changes needed to support the renaming
There was a problem hiding this comment.
Updated in c1e1823
There was a problem hiding this comment.
if it exists but is truly unused, those names seem fine to me.
There was a problem hiding this comment.
As I recall, on the CVT vehicles, the message itself has data in other bytes, however only on the MT vehicles does GEAR_MT actually have data. On CVT vehicles GEAR_MT is always zero. I'm working on getting access again to the CVT integra device that I can confirm this.
You are saying though that even if there is data in other bytes on the CVT vehicles that you are fine naming the message GEARBOX_MT or GEARBOX_MANUAL ?
There was a problem hiding this comment.
From this route on a CVT integra you can see that there is other data on this message, but the GEAR_MT signal is always 0. 3f8ae015ce70365f/000000fe--b691f954c2
Adds a manual transmission gear signal on new ID.
I have a test user with a CVT integra and one with a MT Integra. The CVT does have 0x1DD on CAN bus, but this signal is always 0. On the MT Integra the signal changes based on gear.
Verification : 61e73b2b0226d1a7/0000002a--c9db9c1967 (Integra) and 2d33198e4ff0ee67/00000006--9852f1fdf9 (Civic Type R)