Toyota: add alternate brake pressed bit #551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshane
force-pushed
the
toyota-common-brake
branch
from
38e99fb
to
3f92746
Compare
|
I can confirm that this signal exists on my Prius. |
|
Checked this signal a while ago and recall it didn't catch every brake pressed case on all Toyotas, will look into it again and close if this signal doesn't work for all cars. |
|
Adding another bit in #794 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bit may be common across all 3 platforms, I checked a Corolla (new_mc) and a HighlanderH (tnga_k), but not nodsu yet. For both routes, their respective
BRAKE_MODULEbrake pressed signal matched up perfectly.Draft PR until we take a better look at this.
openpilot issue: commaai/openpilot#23706