Cleanup dead code in CAN parser + packer #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
budney
pushed a commit
to budney/opendbc
that referenced
this pull request
Mar 25, 2022
3f41058 not needed most of the time eab58f6 hyundai: fix TCS13 signals (commaai#576) 908dc0d Put back parser::lookup_message (commaai#578) a10347b Cleaned up Tesla PR commaai#368 (commaai#577) 859fea7 CAN FD support in packer + parser (commaai#568) 0ccc718 run generator 6b784ab Toyota: comments for LTA steering signals (commaai#571) 298c830 Cleanup dead code in CAN parser + packer (commaai#573) a604b15 BMW updates (commaai#572) 7a8f634 Update Jinja2 to fix markupsafe error (commaai#570) f475c35 Toyota: add initializing signal for steer torque message (commaai#566)
budney
added a commit
to budney/opendbc
that referenced
this pull request
Mar 27, 2022
859fea7 CAN FD support in packer + parser (commaai#568) 0ccc718 run generator 6b784ab Toyota: comments for LTA steering signals (commaai#571) 298c830 Cleanup dead code in CAN parser + packer (commaai#573) a604b15 BMW updates (commaai#572) 7a8f634 Update Jinja2 to fix markupsafe error (commaai#570)
budney
pushed a commit
to budney/opendbc
that referenced
this pull request
Mar 28, 2022
From: commaai/master Merge: f475c35^..3f41058 3f41058 not needed most of the time eab58f6 hyundai: fix TCS13 signals (commaai#576) 908dc0d Put back parser::lookup_message (commaai#578) a10347b Cleaned up Tesla PR commaai#368 (commaai#577) 859fea7 CAN FD support in packer + parser (commaai#568) 0ccc718 run generator 6b784ab Toyota: comments for LTA steering signals (commaai#571) 298c830 Cleanup dead code in CAN parser + packer (commaai#573) a604b15 BMW updates (commaai#572) 7a8f634 Update Jinja2 to fix markupsafe error (commaai#570) f475c35 Toyota: add initializing signal for steer torque message (commaai#566)
budney
pushed a commit
to budney/opendbc
that referenced
this pull request
Jun 8, 2022
* remove duplicate implementation * Cleanup dead code in CAN parser + packer * little more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.