Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HKG CAN-FD: Second alternate GEAR message #768

Merged
merged 4 commits into from
Jan 12, 2023
Merged

HKG CAN-FD: Second alternate GEAR message #768

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e47504
Second alternate GEAR message
sunnyhaibin Dec 21, 2022
3d9a20a
Wrong bits!
sunnyhaibin Dec 21, 2022
8e0771e
32 bytes
sunnyhaibin Jan 4, 2023
f37a79c
Merge remote-tracking branch 'commaai/opendbc/master' into hkg-canfd-…
sunnyhaibin Jan 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions hyundai_canfd.dbc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,11 @@ BO_ 101 BRAKE: 32 XXX
SG_ BRAKE_POSITION : 40|16@1- (1,0) [0|65535] "" XXX
SG_ BRAKE_PRESSED : 57|1@1+ (1,0) [0|3] "" XXX

BO_ 112 GEAR_ALT_2: 32 XXX
SG_ CHECKSUM : 0|16@1+ (1,0) [0|65535] "" XXX
SG_ COUNTER : 16|8@1+ (1,0) [0|255] "" XXX
SG_ GEAR : 60|3@1+ (1,0) [0|7] "" XXX

BO_ 160 WHEEL_SPEEDS: 24 XXX
SG_ CHECKSUM : 0|16@1+ (1,0) [0|65535] "" XXX
SG_ COUNTER : 16|8@1+ (1,0) [0|255] "" XXX
Expand Down Expand Up @@ -562,6 +567,7 @@ CM_ SG_ 1043 COUNTER_ALT "only increments on change";
VAL_ 53 GEAR 0 "P" 5 "D" 6 "N" 7 "R" ;
VAL_ 64 GEAR 0 "P" 5 "D" 6 "N" 7 "R" ;
VAL_ 69 GEAR 0 "P" 5 "D" 6 "N" 7 "R" ;
VAL_ 112 GEAR 0 "P" 5 "D" 6 "N" 7 "R" ;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is right, in this route it's saying 4 is drive: https://cabana.comma.ai/?route=db04d2c63990e3ba%7C2022-12-21--15-25-04&seekTime=14&url=https%3A%2F%2Fchffrprivate.azureedge.net%2Fchffrprivate3%2Fv2%2Fdb04d2c63990e3ba%2F86251558a0e6b7d20794b1dd3a57377d_2022-12-21--15-25-04

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this is right, in this route it's saying 4 is drive: https://cabana.comma.ai/?route=db04d2c63990e3ba%7C2022-12-21--15-25-04&seekTime=14&url=https%3A%2F%2Fchffrprivate.azureedge.net%2Fchffrprivate3%2Fv2%2Fdb04d2c63990e3ba%2F86251558a0e6b7d20794b1dd3a57377d_2022-12-21--15-25-04

@sshane It's showing up as 5 is drive on my end in this route. Maybe a bug with cabana?
image

VAL_ 80 LKA_ICON 0 "hidden" 1 "grey" 2 "green" 3 "flashing green" ;
VAL_ 80 LKA_MODE 1 "warning only" 2 "assist" 6 "off" ;
VAL_ 234 LKA_FAULT 0 "ok" 1 "lka fault" ;
Expand Down