CANParser: parse all signals for given messages #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revert default bus behavior
sshane
added a commit
that referenced
this pull request
Aug 5, 2023
sshane
approved these changes
Aug 5, 2023
rjsmith1999
pushed a commit
to rjsmith1999/opendbc
that referenced
this pull request
Aug 31, 2023
rjsmith1999
pushed a commit
to rjsmith1999/opendbc
that referenced
this pull request
Aug 31, 2023
* CANParser: parse all signals for a message * update tests * just use a pair * rm enforce checks * rm that * spacing * fix nonexistent message test * message addr check should not have been deleted * can be cleaned up more * remove that too * add comment back * revert default bus behavior revert default bus behavior * can combine this loop * unused map * add all * ensure we track all signals * remove sanity check * this wasn't tested before * Revert "this wasn't tested before" This reverts commit eb5e920. --------- Co-authored-by: Shane Smiskol <shane@smiskol.com>
eFiniLan
pushed a commit
to eFiniLan/opendbc
that referenced
this pull request
Aug 31, 2023
eFiniLan
pushed a commit
to eFiniLan/opendbc
that referenced
this pull request
Aug 31, 2023
* CANParser: parse all signals for a message * update tests * just use a pair * rm enforce checks * rm that * spacing * fix nonexistent message test * message addr check should not have been deleted * can be cleaned up more * remove that too * add comment back * revert default bus behavior revert default bus behavior * can combine this loop * unused map * add all * ensure we track all signals * remove sanity check * this wasn't tested before * Revert "this wasn't tested before" This reverts commit eb5e920. --------- Co-authored-by: Shane Smiskol <shane@smiskol.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.