You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Note that isDefaultClosed and isMultilineDefaultExpanded address the same concern. However they're worded differently and they even have opposite default states.
Similarily, isDefaultExpanded and areLanguagesDefaultOpened address the same concern. Their wording is completely different as well and they have opposite defaults too.
Solution
We can boil the four different prop names down to just two different prop names; one for each concept.
Problem
At the moment we use a mix of props to basically explain the same two concerns, which adds unnecessary mental overhead when using our components.
The two properties we need to address
At the moment we use the following props to express this:
MultilineTextInput
isDefaultClosed
LocalizedTextInput
isDefaultExpanded
LocalizedMultilineTextInput
isMultilineDefaultExpanded
areLanguagesDefaultOpened
Note that
isDefaultClosed
andisMultilineDefaultExpanded
address the same concern. However they're worded differently and they even have opposite default states.Similarily,
isDefaultExpanded
andareLanguagesDefaultOpened
address the same concern. Their wording is completely different as well and they have opposite defaults too.Solution
We can boil the four different prop names down to just two different prop names; one for each concept.
MultilineTextInput
isMultilineDefaultExpanded
LocalizedTextInput
areLanguagesDefaultOpened
LocalizedMultilineTextInput
isMultilineDefaultExpanded
areLanguagesDefaultOpened
I'm not too enthusiastic about these names and I'd welcome suggestions 👂
The text was updated successfully, but these errors were encountered: