Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build progress counter is no longer visible #1685

Closed
bergmark opened this issue Jan 20, 2016 · 1 comment
Closed

build progress counter is no longer visible #1685

bergmark opened this issue Jan 20, 2016 · 1 comment
Labels
Milestone

Comments

@bergmark
Copy link
Member

@bergmark bergmark commented Jan 20, 2016

I noticed this after upgrading to 1.0.2, the progress counter never shows when building multiple packages, instead there's just an empty line. If i hit Ctrl-C the progress prints before stack exits

test-1: build
^CProgress: 0/37user interrupt
Progress: 1/37⏎
@mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Jan 21, 2016

Hmm, good point! Regression caused by 3003354 , should have tested that more thoroughly. The fix is to flush stderr after writing the sticky message.

@mgsloan mgsloan closed this Jan 21, 2016
@mgsloan mgsloan added the type: bug label Jan 21, 2016
@mgsloan mgsloan added this to the P2: Should milestone Jan 21, 2016
mgsloan added a commit that referenced this issue Jan 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants