--ghc-options only takes a single option

[mgsloan]

From the comment here #758 (comment) :

$ stack ghci --ghc-options="-ddump-simpl -dsuppress-idinfo"
Configuring GHCi with the following packages:
GHCi, version 8.0.2: http://www.haskell.org/ghc/  :? for help
ghc.EXE: unrecognised flag: -ddump-simpl -dsuppress-idinfo

Usage: For basic information, try the `--help' option.

Curiously, the documentation on the argsOption function that handles this mentions --ghc-options, but it isn't currently used:

-- | An option which accepts a list of arguments e.g. @--ghc-options="-X P.hs \"this\""@.
argsOption :: O.Mod O.OptionFields [String] -> O.Parser [String]

Fix is to use this for ghc-options and make sure it's also used for other similar options fields

[decentral1se]

Done in 9e2bd40.

[mgsloan]

Re-opening this. Here's what happened:

• The fix broke another usecase - A way to pass RTS options to the GHC #3353

• We want to do a release soon.

• I don't want to try implementing any complex solution this close to release, so I reverted the fix to this.

Note that any future fix to this should also consider the usecase in #3353. It is also worthwhile to take a look at how ghc-options and ghcjs-options work in the stack configuration, and have it be consistent with the CLI in its parsing.

[sclausen]

@mgsloan I would be glad, if you could tell, what the status of this is.

[mgsloan]

@sclausen I think the proper steps forward were in the other issue #3353 (comment) . Copying what I said there:

Actually, I think that this was never a problem for configure-options, just an issue when invoking ghci directly with multi-ghc-options. I noticed that the configuration parsing code for stack.yaml uses argument parsing for "ghc-options", when it probably shouldn't. So, steps would be:

• Use parseArgs for options passed to ghci
• Remove use of parseArgs for --ghc-options in cli and ghc-options: in config

Also, some stuff to make sure this doesn't regress:

• Add tests for mutltiword options that both build and invoke ghc ( tswelsh@9832fd9 + more)
• Add tests for multiword options that include RTS options.

[sclausen]

@mgsloan thanks for the quick answer!

[snoyberg]

See #4747