Make --ghc-options and --ghcjs-boot-options take multiple args #3315 #3316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mgsloan
commented
Aug 6, 2017
mgsloan
commented
- Any changes that could be relevant to users have been recorded in the ChangeLog.md
- The documentation has been updated, if necessary.
mgsloan
changed the title
mgsloan
force-pushed
the
multiword-ghc-options
branch
from
c7b9e82
to
215bac0
Compare
decentral1se
reviewed
Aug 7, 2017
src/Options/Applicative/Args.hs
Outdated
| argsArgument :: O.Mod O.ArgumentFields [String] -> O.Parser [String] | ||
| argsArgument = | ||
| O.argument | ||
| (do string <- O.str | ||
| either O.readerError return (parseArgsFromString string)) | ||
|
|
||
| -- | Like 'textArgsOption', but allows the option to be used multiple | ||
| -- time. The options get concatenated. |
decentral1se
force-pushed
the
multiword-ghc-options
branch
from
215bac0
to
c3bbe9a
Compare
|
Took a stab at fixing that comment and adding a test to move this one along! |
decentral1se
force-pushed
the
multiword-ghc-options
branch
from
c3bbe9a
to
c30d959
Compare
|
Thanks @lwm ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.