Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upCanonicalizes temporary directory paths #1047
Conversation
robstewart57
referenced this pull request
Sep 24, 2015
Closed
Canonicalises path from withSystemTempDirectory #1019
robstewart57
force-pushed the
robstewart57:master
branch
from
0704d0c
to
cf6d1cf
Sep 24, 2015
snoyberg
reviewed
Sep 25, 2015
| withCanonicalizedSystemTempDirectory :: (MonadMask m, MonadIO m) | ||
| => String -- ^ Directory name template. | ||
| -> (FilePath -> m a) -- ^ Callback that can use the canonicalized directory |
This comment has been minimized.
This comment has been minimized.
snoyberg
Sep 25, 2015
Contributor
I'd actually been thinking this would be a Path Abs Dir, to make it fit in with the rest of this module and avoid the need for the parseAbsDir in all of the call sites.
robstewart57
referenced this pull request
Sep 25, 2015
Closed
Adds a canonicalised version of withSystemTempDirectory #16
snoyberg
merged commit cf6d1cf
into
commercialhaskell:master
Sep 27, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
robstewart57 commentedSep 24, 2015
When the $TMPDIR environment variable is set, the directory paths
provided by
withSystemTempDirectoryandwithTempDirectoryfromSystem.IO.Temp provided by the temporary library are not
canonicalised. This commit wraps these functions into canonicalized
versions.
See an earlier PR for discussion #1019
Fixes #1017