Canonicalizes temporary directory paths #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the $TMPDIR environment variable is set, the directory paths provided by `withSystemTempDirectory` and `withTempDirectory` from System.IO.Temp provided by the temporary library are not canonicalised. This commit wraps these functions into canonicalized versions. See an earlier PR for discussion commercialhaskell#1019 Fixes commercialhaskell#1017
robstewart57
force-pushed
the
master
branch
from
0704d0c
to
cf6d1cf
Compare
|
|
||
| withCanonicalizedSystemTempDirectory :: (MonadMask m, MonadIO m) | ||
| => String -- ^ Directory name template. | ||
| -> (FilePath -> m a) -- ^ Callback that can use the canonicalized directory |
There was a problem hiding this comment.
I'd actually been thinking this would be a Path Abs Dir, to make it fit in with the rest of this module and avoid the need for the parseAbsDir in all of the call sites.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the $TMPDIR environment variable is set, the directory paths
provided by
withSystemTempDirectoryandwithTempDirectoryfromSystem.IO.Temp provided by the temporary library are not
canonicalised. This commit wraps these functions into canonicalized
versions.
See an earlier PR for discussion #1019
Fixes #1017