Fix package promotion to snapshot #3758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borsboom
reviewed
Jan 11, 2018
| @@ -0,0 +1 @@ | |||
| resolver: lts-3.12 | |||
There was a problem hiding this comment.
Having integration tests with old resolvers will cause them to fail on Linux distributions with GCC with PIE enabled by default (which is the latest versions of most distributions now), since older GHC versions don't support it. I'm not sure what we should do about this, since it obviously does make sense to be able to test against old snapshots sometimes.
I haven't confirmed this, but I believe also that, if ~/.stack doesn't already happen to have the required GHC version installed, every time the test is run it will re-install GHC which makes the tests take extra long.
There was a problem hiding this comment.
Alright, new commit pushed that should address this.
See added README.md for an explanation of why we're doing this and why this test actually matters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes commercialhaskell/stackage#3185
Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!