-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't recompile in presence of sublibraries #3955
Don't recompile in presence of sublibraries #3955
Conversation
…clause to be reused next
…ere clause to be reused next
@mgsloan, can this be merged/released sooner rather than later? Full rebuilds on every action are a huge pain. |
Agreed. This is killing my productivity. |
If there's any need for more work on this, I'd be happy to do it. |
Sorry for the delay on reviewing this. Two comments:
Thank you for this PR! |
Sure. I'll do both this week. |
And done, was easier than expected to add the test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! @borsboom I think this is worth including in the 1.7 release.
Don't recompile in presence of sublibraries (cherry picked from commit a3a8754)
I've cherry-picked into the |
A practical benefit is that we can control the build-depends and also avoid some recompilation between library and test-suite.
@borsboom can we get a |
@borsboom Thanks! 🙂 Update: confirmed that this fixes the rebuilding. |
Note: use latest stack (1.7.1) to avoid problems with recompiling all haddock/pandoc: commercialhaskell/stack#3955
Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.
Please include the following checklist in your PR:
Please also shortly describe how you tested your change. Bonus points for added tests!
Tested first with the
internal-libraries
package mentioned in #3899 (comment) and made Stack not ignore the internal library in this case.Furthermore, tested against my own
hakyll
-based repo, to reproduce #3899.