Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't recompile in presence of sublibraries #3955

Merged
merged 15 commits into from
Apr 17, 2018
Merged

Don't recompile in presence of sublibraries #3955

merged 15 commits into from
Apr 17, 2018

Conversation

mihaimaruseac
Copy link
Contributor

@mihaimaruseac mihaimaruseac commented Apr 6, 2018

Note: Documentation fixes for https://docs.haskellstack.org/en/stable/ should target the "stable" branch, not master.

Please include the following checklist in your PR:

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

Please also shortly describe how you tested your change. Bonus points for added tests!


Tested first with the internal-libraries package mentioned in #3899 (comment) and made Stack not ignore the internal library in this case.

Furthermore, tested against my own hakyll-based repo, to reproduce #3899.

@mihaimaruseac mihaimaruseac changed the title Don't recompile in presense of sublibraries Don't recompile in presence of sublibraries Apr 6, 2018
@lierdakil
Copy link

@mgsloan, can this be merged/released sooner rather than later? Full rebuilds on every action are a huge pain.

@rcook
Copy link

rcook commented Apr 12, 2018

Agreed. This is killing my productivity.

@mihaimaruseac
Copy link
Contributor Author

If there's any need for more work on this, I'd be happy to do it.

@snoyberg
Copy link
Contributor

Sorry for the delay on reviewing this. Two comments:

  1. It would be ideal if you could add an integration test to ensure this works and that the bug doesn't recur in the future. (See: https://github.com/commercialhaskell/stack/tree/d0bf58a2a663bfb81e67a6af5e752387b22d4a2e/test/integration)
  2. Would it be possible to do away with the usage of fromJust? We generally try to skip partial functions in the codebase

Thank you for this PR!

@mihaimaruseac
Copy link
Contributor Author

Sure. I'll do both this week.

@mihaimaruseac
Copy link
Contributor Author

And done, was easier than expected to add the test.

Copy link
Contributor

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! @borsboom I think this is worth including in the 1.7 release.

@snoyberg snoyberg merged commit a3a8754 into commercialhaskell:master Apr 17, 2018
borsboom pushed a commit that referenced this pull request Apr 17, 2018
Don't recompile in presence of sublibraries
(cherry picked from commit a3a8754)
@borsboom
Copy link
Contributor

borsboom commented Apr 17, 2018

I've cherry-picked into the v1.7.0 (next release) branch.

mihaimaruseac referenced this pull request in haskell/haddock Apr 17, 2018
A practical benefit is that we can control the build-depends and also
avoid some recompilation between library and test-suite.
@Porges
Copy link
Contributor

Porges commented Apr 19, 2018

@borsboom can we get a 1.7.0.2 build? I'm in so much pain 😁

@borsboom
Copy link
Contributor

@Porges https://github.com/commercialhaskell/stack/releases/tag/v1.7.0.3

@Porges
Copy link
Contributor

Porges commented Apr 19, 2018

@borsboom Thanks! 🙂

Update: confirmed that this fixes the rebuilding.

@mihaimaruseac mihaimaruseac mentioned this pull request May 2, 2018
2 tasks
MonoidMusician added a commit to eviefp/caudex that referenced this pull request May 25, 2018
Note: use latest stack (1.7.1) to avoid problems with recompiling all haddock/pandoc: commercialhaskell/stack#3955
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants