Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent handling of internal libraries #4111

Merged
merged 20 commits into from
Jun 23, 2018
Merged

Consistent handling of internal libraries #4111

merged 20 commits into from
Jun 23, 2018

Conversation

mihaimaruseac
Copy link
Contributor

  • Any changes that could be relevant to users have been recorded in the ChangeLog.md
  • The documentation has been updated, if necessary.

This checks for all the places where we need to handle internal libraries and handles them. As a result, it closes #3787, #4071 and #4105.

@mihaimaruseac
Document changes in ChangeLog.md.
3e2202a
@mihaimaruseac
Don't recompute package
88d1da3
@mihaimaruseac
Handle sublibs when determining plan dependencies.
47347b5
@mihaimaruseac
Handle sublibs when determining if a package has wanted components.
db230c2
@mihaimaruseac
Announce when building sublibraries
4a4b63f
@mihaimaruseac
Refactor to have an easier to read expression
62771ef
@mihaimaruseac
Handle sublibs when determining if a build result needs copying.
d5a04f5
@mihaimaruseac
Shorten line by factoring out the check for executables
95e88fc
@mihaimaruseac
Extract common expression.
964a46c
@mihaimaruseac
Allow building with sublibs and no libs (#3787).
7e8fd9d
@mihaimaruseac
Handle sublibs in coverage reports.
43f37d8
@mihaimaruseac
Add sublibraries to the precompiled cache.
8d94aaf 
Next commit will actually handle the addition, for now these are
stubs/empty lists.
@mihaimaruseac
Store the sublibraries in the precompiled cache after building.
af27253 
Next commit will handle reloading them from the cache when switching to
a new snapshot.
@mihaimaruseac
Properly handle precompiled cache entries for sublibraries.
9c1d512
@mihaimaruseac
Make sure we don't cache sublibraries when there is no library.
8bfab46
@mihaimaruseac
Update the ChangeLog description of the coverage bug fix.
3e1c7d3
@mihaimaruseac
Add integration test for #3787
013d1c4
@mihaimaruseac
Add integration test for #4105
0ec3063
@mihaimaruseac
Style fixes
7d5ddd6
@mihaimaruseac @mihaimaruseacleapyear
One more style fix
cbe07a0
@mihaimaruseac mihaimaruseac merged commit d6dd041 into master Jun 23, 2018
@mihaimaruseac mihaimaruseac deleted the mm-more-internal-libraries branch June 23, 2018 00:13
This was referenced Jun 23, 2018
Closed
Closed
@dbaynard dbaynard mentioned this pull request Jun 26, 2018
Closed
@mihaimaruseac mihaimaruseac mentioned this pull request Jul 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Internal libraries does not work if there's no main library
1 participant
@mihaimaruseac