Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use distinct output for boolean logic #5859

Merged

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Sep 9, 2022

Note: Fixes for the online documentation of the current Stack release (https://docs.haskellstack.org/en/stable/) should target the 'stable' branch, not the 'master' branch.

Please include the following checklist in your pull request:

  • Any changes that could be relevant to users have been recorded in ChangeLog.md.
  • The documentation has been updated, if necessary

Please also shortly describe how you tested your change. Bonus points for added tests!

  1. I tried pulling in the latest master hoping everything would work: https://github.com/check-spelling/stack/runs/8276358068?check_suite_focus=true
    -- it didn't, apparently the value comparison logic didn't end up w/ the values we wanted
  2. I tried a number of combinations... https://github.com/check-spelling/stack/actions
  3. This combination did the right thing for forks w/o the secret: https://github.com/check-spelling/stack/runs/8277415398?check_suite_focus=true
  4. Then I added the secret and got a run that appears to be properly waiting for a runner: https://github.com/check-spelling/stack/runs/8277460422?check_suite_focus=true
Requested labels: self-hosted, linux, ARM64
Job defined at: check-spelling/stack/.github/workflows/integration-tests.yml@refs/heads/master
Waiting for a runner to pick up this job...

I'll cancel it at some point...

@mpilgrem mpilgrem merged commit 5f19599 into commercialhaskell:master Sep 9, 2022
@jsoref jsoref deleted the integration-tests-in-forks branch September 9, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants