Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why hasn't MemoTrie been updated from 0.6.4? #1999

Closed
sjakobi opened this issue Oct 18, 2016 · 2 comments
Closed

Why hasn't MemoTrie been updated from 0.6.4? #1999

sjakobi opened this issue Oct 18, 2016 · 2 comments

Comments

@sjakobi
Copy link
Member

sjakobi commented Oct 18, 2016

As reported in conal/MemoTrie#10 and commercialhaskell/stack#2719, MemoTrie-0.6.4 has broken haddocks, which makes it hard to generate haddocks for packages that depend on it.

Since MemoTrie-0.6.5 which includes a fix for the haddocks has been out since 2016-09-11 I'm wondering why lts-7 and nightly haven't been updated? Is it because of the of the additional dependency on newtype-generics?

Relatedly I'm wondering if working haddocks should be enforced more strictly on stackage as broken haddocks pose quite the inconvenience for all downstream packages.

@sjakobi
Copy link
Member Author

sjakobi commented Oct 18, 2016

Ok, newtype-generics doesn't support base-4.9… :(

Closing as I don't see anything that stackage could do about this.

@sjakobi sjakobi closed this as completed Oct 18, 2016
@bergmark
Copy link
Member

Yes the upper bound was introduced in #1863, since MemoTrie added that dependency.

We do enforce haddocks and will put an upper bound in place if haddocks fail unless there are special circumstances (see "expected-haddock-failures" in build-constraints.yaml).

I'm not sure why MemoTrie was added with failing haddocks though, a comment explaining why is missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants