Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yesod-core-1.6.10 #4319

Closed
alexeyzab opened this Issue Jan 22, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@alexeyzab
Copy link
Contributor

alexeyzab commented Jan 22, 2019

Preprocessing test suite 'tests' for yesod-core-1.6.10..
Building test suite 'tests' for yesod-core-1.6.10..
[ 1 of 32] Compiling YesodCoreTest.Auth ( test/YesodCoreTest/Auth.hs, dist/build/tests/tests-tmp/YesodCoreTest/Auth.o )
[ 2 of 32] Compiling YesodCoreTest.Cache ( test/YesodCoreTest/Cache.hs, dist/build/tests/tests-tmp/YesodCoreTest/Cache.o )

test/YesodCoreTest/Cache.hs:69:5: error:
    • No instance for (Control.Monad.Fail.MonadFail (HandlerFor C))
        arising from a do statement
        with the failable pattern ‘Just (V2 v4a)’
    • In a stmt of a 'do' block: Just (V2 v4a) <- cacheByGet "4"
      In the expression:
        do ref <- newIORef 0
           V1 v1a <- cachedBy "1"
                       $ atomicModifyIORef ref $ \ i -> (i + 1, V1 $ i + 1)
           V1 v1b <- cachedBy "1"
                       $ atomicModifyIORef ref $ \ i -> (i + 1, V1 $ i + 1)
           V2 v2a <- cachedBy "1"
                       $ atomicModifyIORef ref $ \ i -> (i + 1, V2 $ i + 1)
           ....
      In an equation for ‘getKeyR’:
          getKeyR
            = do ref <- newIORef 0
                 V1 v1a <- cachedBy "1" $ atomicModifyIORef ref $ \ i -> ...
                 V1 v1b <- cachedBy "1" $ atomicModifyIORef ref $ \ i -> ...
                 ....
   |
69 |     Just (V2 v4a) <- cacheByGet "4"
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Going to add to expected-test-failures for now. CC @snoyberg

alexeyzab added a commit that referenced this issue Jan 22, 2019

snoyberg added a commit to yesodweb/yesod that referenced this issue Jan 22, 2019

snoyberg added a commit that referenced this issue Jan 22, 2019

@snoyberg

This comment has been minimized.

Copy link
Contributor

snoyberg commented Jan 22, 2019

Thanks @alexeyzab, I've opened #4320 after making a new release.

@MaxGabriel

This comment has been minimized.

Copy link
Contributor

MaxGabriel commented Jan 22, 2019

Thanks @alexeyzab, not sure why I didn't run into that

@snoyberg

This comment has been minimized.

Copy link
Contributor

snoyberg commented Jan 22, 2019

@MaxGabriel

This comment has been minimized.

Copy link
Contributor

MaxGabriel commented Jan 22, 2019

Oh that's right, makes sense 👍

alexeyzab added a commit that referenced this issue Jan 23, 2019

Merge pull request #4320 from commercialhaskell/yesod-core-passes-again
Revert "Expect test failures for yesod-core, #4319"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.