yesod-core-1.6.10

[alexeyzab]

Preprocessing test suite 'tests' for yesod-core-1.6.10..
Building test suite 'tests' for yesod-core-1.6.10..
[ 1 of 32] Compiling YesodCoreTest.Auth ( test/YesodCoreTest/Auth.hs, dist/build/tests/tests-tmp/YesodCoreTest/Auth.o )
[ 2 of 32] Compiling YesodCoreTest.Cache ( test/YesodCoreTest/Cache.hs, dist/build/tests/tests-tmp/YesodCoreTest/Cache.o )

test/YesodCoreTest/Cache.hs:69:5: error:
    • No instance for (Control.Monad.Fail.MonadFail (HandlerFor C))
        arising from a do statement
        with the failable pattern ‘Just (V2 v4a)’
    • In a stmt of a 'do' block: Just (V2 v4a) <- cacheByGet "4"
      In the expression:
        do ref <- newIORef 0
           V1 v1a <- cachedBy "1"
                       $ atomicModifyIORef ref $ \ i -> (i + 1, V1 $ i + 1)
           V1 v1b <- cachedBy "1"
                       $ atomicModifyIORef ref $ \ i -> (i + 1, V1 $ i + 1)
           V2 v2a <- cachedBy "1"
                       $ atomicModifyIORef ref $ \ i -> (i + 1, V2 $ i + 1)
           ....
      In an equation for ‘getKeyR’:
          getKeyR
            = do ref <- newIORef 0
                 V1 v1a <- cachedBy "1" $ atomicModifyIORef ref $ \ i -> ...
                 V1 v1b <- cachedBy "1" $ atomicModifyIORef ref $ \ i -> ...
                 ....
   |
69 |     Just (V2 v4a) <- cacheByGet "4"
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Going to add to expected-test-failures for now. CC @snoyberg

[snoyberg]

Thanks @alexeyzab, I've opened #4320 after making a new release.

[MaxGabriel]

Thanks @alexeyzab, not sure why I didn't run into that

[snoyberg]

It only kicks in on GHC 8.6, and we never updated Yesod's CI to test against that. I opened a PR to add that testing.

…

On Tue, Jan 22, 2019, 10:00 PM Maximilian Tagher ***@***.*** wrote: Thanks @alexeyzab <https://github.com/alexeyzab>, not sure why I didn't run into that — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4319 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADBB7G7tQIXlM8Yu6ZfWmBgreujOIGyks5vF23pgaJpZM4aM-QV> .

[MaxGabriel]

Oh that's right, makes sense 👍