Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Expect test failures for yesod-core, #4319" #4320

Merged
merged 1 commit into from
Jan 23, 2019

Conversation

snoyberg
Copy link
Contributor

This reverts commit f7a18fb.

Fixes #4319

Checklist:

  • Meaningful commit message, eg add my-cool-package (please not mention build-constraints.yml)

  • At least 30 minutes have passed since uploading to Hackage

  • On your own machine, in a new directory, you have successfully run the following set of commands (replace $package with the name of the package that is submitted, and $version with the version of the package you want to get into Stackage):

    stack unpack $package-$version  # $version is optional
    stack init --resolver nightly
    stack build --resolver nightly --haddock --test --bench --no-run-benchmarks
    

@snoyberg snoyberg mentioned this pull request Jan 22, 2019
@alexeyzab
Copy link
Contributor

Thanks!

@alexeyzab alexeyzab merged commit 92db2ac into master Jan 23, 2019
@mihaimaruseac mihaimaruseac deleted the yesod-core-passes-again branch February 15, 2020 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yesod-core-1.6.10
2 participants