Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For granted sso generate/populate commands add support to persist preferences in .granted/config #650

Closed
ibottamike opened this issue May 2, 2024 · 1 comment

Comments

@ibottamike
Copy link
Contributor

The granted sso generate/populate commands have input for StartURL, SsoRegion, Prefix, Source, NoCredentialProcess, and ProfileTemplate.

Only having the parameters available as input variables require them to be enter every time the commands are run. In a dynamic environment where AWS accounts are added/removed, this requires the variables to be stored outside of granted configuration.

Add the capability to store the configuration values in .granted/config to be consistent with registry add/sync and assume browser preferences.

chrnorm added a commit that referenced this issue May 3, 2024
…651)

* for granted sso command, add storing parameters in input config

This reverts commit 00d95e1.

* remove println

* support multiple section names and remove deprecated source from config

* remove println

* For profile-template with a default, check IsSet instead of having a value

* simplify referencing cfgSSO

* add glag to populate

* Update pkg/config/config.go

* Update pkg/granted/sso.go

---------

Co-authored-by: ibottamike <mike.sarver@ibotta.com>
Co-authored-by: Chris Norman <17420369+chrnorm@users.noreply.github.com>
@chrnorm
Copy link
Contributor

chrnorm commented Jun 4, 2024

Implemented in #651!

@chrnorm chrnorm closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants