for granted sso command, add storing parameters in input config https://github.com/common-fate/granted/issues/650 #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrnorm
requested changes
May 3, 2024
There was a problem hiding this comment.
Thanks very much for this @mikesarver, I am very keen to improve the UX with profile generation and avoiding having to pass all those extra flags. I've requested changes on a couple of smaller nits, as well as some thinking around how we might make this useable for folks who have multiple AWS SSO instances they work with.
chrnorm
reviewed
May 3, 2024
chrnorm
reviewed
May 3, 2024
chrnorm
approved these changes
May 3, 2024
There was a problem hiding this comment.
Tested this locally and it's working great! Thanks so much @mikesarver 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
For
granted sso generate/populatecommands add support to persist preferences in .granted/configWhy?
issues/650
Persists
granted ssopreferences in~/.granted/config. This allows storing preferences in granted config across commands. This allows persisting the data once in config and used across when running commands to sync profiles.How did you test it?
Tested manually.
Potential risks
Is patch release candidate?
Link to relevant docs PRs