Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sso generate/populate expected behaviour clearer #332

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

connorads
Copy link
Contributor

@connorads connorads commented Jan 11, 2023

Describe your changes

Update log line to make it clearer to first time users of granted sso generate or granted sso populate that it's not just signing in but it's also downloading accounts/creating profiles at could take longer than a few seconds.

Before: [i] Once you press 'Allow', the sign in process will complete in a few seconds
After: [i] Once you press 'Allow', the sign in process and account fetching should complete in a few seconds (can take longer if SSO has many accounts)

PS. I'm not precious about the wording feel free to edit it and push changes to the PR 🤗

Why tho?

When running granted sso generate or granted sso populate after clicking Allow in AWS on my browser I thought granted was broken because the login took longer than "a few seconds" as mentioned by the log - it was stuck there for 5-10 seconds before I would Ctrl+c and kill the granted process.

I kept doing this until one time I waited 20+ seconds and it actually worked 🫠
This is for 160 AWS accounts by the way 👀

image

Type of change

Updating a log statement 🤓

Issue and Documentation

See above 🤷

Testing

Please describe how the reviewer can test the changes. Also include steps to reproduce the testing environment.

  1. Run granted sso generate --region eu-west-1 https://example.awsapps.com/start with your SSO URL and region
  2. (Optional) Log in to AWS via newly launched browser
  3. Look at terminal to see new log message ✨

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • Do analytics need to be implemented?
  • I have made corresponding changes to the documentation, docs PR has been linked.
  • New and existing unit tests pass with my changes.
  • Any dependent changes have been merged and published in downstream modules.

image

@connorads connorads changed the title Update logging statement Make sso generate/populate expected behaviour clearer Jan 11, 2023
@connorads connorads marked this pull request as ready for review January 11, 2023 21:21
Copy link
Contributor

@JoshuaWilkes JoshuaWilkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@JoshuaWilkes JoshuaWilkes merged commit 4d9aa2f into common-fate:main Jan 16, 2023
@connorads connorads deleted the patch-1 branch January 16, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants