Make sso generate/populate expected behaviour clearer #332
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Update log line to make it clearer to first time users of
granted sso generate
orgranted sso populate
that it's not just signing in but it's also downloading accounts/creating profiles at could take longer than a few seconds.Before:
[i] Once you press 'Allow', the sign in process will complete in a few seconds
After:
[i] Once you press 'Allow', the sign in process and account fetching should complete in a few seconds (can take longer if SSO has many accounts)
PS. I'm not precious about the wording feel free to edit it and push changes to the PR 🤗
Why tho?
When running
granted sso generate
orgranted sso populate
after clickingAllow
in AWS on my browser I thoughtgranted
was broken because the login took longer than "a few seconds" as mentioned by the log - it was stuck there for 5-10 seconds before I wouldCtrl+c
and kill thegranted
process.I kept doing this until one time I waited 20+ seconds and it actually worked 🫠
This is for 160 AWS accounts by the way 👀
Type of change
Updating a log statement 🤓
Issue and Documentation
See above 🤷
Testing
Please describe how the reviewer can test the changes. Also include steps to reproduce the testing environment.
granted sso generate --region eu-west-1 https://example.awsapps.com/start
with your SSO URL and regionChecklist before requesting a review
I have commented my code, particularly in hard-to-understand areas.I have added tests that prove my fix is effective or that my feature works.Do analytics need to be implemented?I have made corresponding changes to the documentation, docs PR has been linked.Any dependent changes have been merged and published in downstream modules.