Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn build fails on unmet dep #8

Closed
twtaylor opened this issue Nov 10, 2022 · 1 comment
Closed

yarn build fails on unmet dep #8

twtaylor opened this issue Nov 10, 2022 · 1 comment

Comments

@twtaylor
Copy link

twtaylor commented Nov 10, 2022

https://www.npmjs.com/package/json-rpc-engine doesn't appear to be pulled in properly. If you look at https://github.com/lightclients/kevlar/blob/90b1c7f2f56efa0669368ced93d12c1824f3dbd7/src/rpc-bundle/rpc-lightclient-middleware.ts#L1 the node module json-rpc-engine is not pulled in from anywhere.

So you'll get something like:

> yarn build
yarn run v1.22.19
$ tsc
src/rpc-bundle/rpc-lightclient-middleware.ts:1:39 - error TS2307: Cannot find module 'json-rpc-engine' or its corresponding type declarations.

1 import { createAsyncMiddleware } from 'json-rpc-engine';
                                        ~~~~~~~~~~~~~~~~~


Found 1 error in src/rpc-bundle/rpc-lightclient-middleware.ts:1

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

If you try to build.

@shresthagrawal
Copy link
Member

@twtaylor thanks for reporting the issue is fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants