-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback about a Wikidata item: Does not exist, Is at other location, other problem #2425
Comments
That sounds like a good idea @nicolas-raoul. There were few points in my mind |
@vanshikaarora Yes, added notes will be visible by all.
|
Just one more question, please. |
They can be published immediately :-) By the way, I see what you mean by "us wikimedia", but I just want to mention that even though our app is an official Wikimedia Foundation (WMF) app, only very few of us (only Vojtech I think) are members of the Wikimedia Foundation, and we historically considered the app to be an independent effort, so we don't speak in the name of Wikimedia. |
Hmmm, I am not sure about this. The bottom panel is already quite full, adding one more item seems to make it quite cluttered. I guess the main reason why I am hesitant is that having this extra item seems to only save the user 1 tap. Since they can just go to the Wikidata item and then tap the "Discussion" tab in their browser. Granted, wiki editing in the mobile browser is a bit clunky. Maybe we could consider a different way to implement this action in the UI. For instance, a small/discreet "Report error" text button somewhere? |
How about making the icons bar movable like the tools bar in the app "Photo
Editor"?
And removing the inactive icons rather than greying them out. For instance,
the "Commons category" icon is grey most of the time.
…On Mon, Feb 11, 2019, 01:02 Josephine Lim ***@***.*** wrote:
Hmmm, I am not sure about this. The bottom panel is already quite full,
adding one more item seems to make it quite cluttered. I guess the main
reason why I am hesitant is that having this extra item seems to only save
the user 1 tap. Since they can just go to the Wikidata item and then tap
the "Discussion" tab in their browser. Granted, wiki editing in the mobile
browser is a bit clunky.
Maybe we could consider a different way to implement this action in the
UI. For instance, a small/discreet "Report error" text button somewhere?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2425 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGFBprIBtRQSekIe7nRKvINDXyr3WxQks5vMEKmgaJpZM4amzeE>
.
On Mon, Feb 11, 2019, 01:02 Josephine Lim ***@***.*** wrote:
Hmmm, I am not sure about this. The bottom panel is already quite full,
adding one more item seems to make it quite cluttered. I guess the main
reason why I am hesitant is that having this extra item seems to only save
the user 1 tap. Since they can just go to the Wikidata item and then tap
the "Discussion" tab in their browser. Granted, wiki editing in the mobile
browser is a bit clunky.
Maybe we could consider a different way to implement this action in the
UI. For instance, a small/discreet "Report error" text button somewhere?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2425 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGFBprIBtRQSekIe7nRKvINDXyr3WxQks5vMEKmgaJpZM4amzeE>
.
|
Removing inactive icons would be fantastic. :) Haven't tried the Photo Editor app yet. |
That sounds like a great idea. I can work on this |
Thanks @vanshikaarora ! I think we don't have a separate issue for that yet, would you mind creating the issue (and stating that you are going to work on it in your post)? |
Sure I'll do that :) |
@nicolas-raoul I am ready to work on this Issue. But before I begin I would like to know how are retrieving/sending these feedback's. Is there an API for it? |
@vanshikaarora Thanks! As you have see, you will need to read and write to a Wikidata item's talk page such as https://www.wikidata.org/wiki/Talk:Q11311478 |
@nicolas-raoul I have gone through the API's available here. And I have found that we can create a new description entity for each of these talks. Here was an API that I have found useful. |
"description" is a different thing, we should not edit it. We must use edit with |
To display the current content of the talk page, https://commons.wikimedia.org/w/api.php?action=help&modules=flow-parsoid-utils (also with |
Ok I'll use this API @nicolas-raoul Here is the work-list for me. That will be available in the next PR:
Is there anything that you would like to add or suggest especially the UI part? |
Writing down this work-list is a great initiative! The content sounds good, for the API I think we have 3 use cases:
|
@nicolas-raoul Is this available currently? |
I don't think so, you will probably have to read the content from the server, then concatenate, then send to the server 🙂 |
@nicolas-raoul I have parsed the API using
And got the following response
Currently the Is this intended? |
You can get the wikitext of the talk page like this: https://www.wikidata.org/w/api.php?action=query&prop=revisions&rvprop=content&titles=Talk:Q11311478 Then either just display it like this (easiest), or put as as the source of your request above (and replace |
@nicolas-raoul Do you mean using a WebView here? |
@nicolas-raoul The above link gives a query like
While I was executing the API there wasn't any node like "revisions" instead the API response looked like
Intsead of "revisions" it returned an empty node "missing". Am I parsing the API correctly here?
|
What do you get with
? |
@nicolas-raoul It returns an object of type CustomApiResult |
Does your IDE allow you to see what is inside this object? |
When I tried calling this API I got the following response:
|
@maskaravivek on using
The following is shown in logs
|
I also used the rvslots param set to main |
@maskaravivek Even then the response was same for me :( |
You need to use |
Thanks @maskaravivek Using this I successfully got the result :)
|
About the UI: How about the one I proposed in the first post above? It does not need to be polished as it is not a place people will see often :-) |
Hi @nicolas-raoul I would like to work on this task, can you assign this to me |
Hello @nicolas-raoul, Can I also start working over this one ? |
@kanahia1 Sure, if you want, thanks! 🙂 |
Hey everyone I was working with API to edit/create page. Each time I used to do a request to edit/create page I receive an error.
I used CSRFTokenClient for getting a token, here's an token for example |
I remember seeing such an issue in the past, you may want to search among closed issues. |
Sure and Thanks :-) |
I tried logging in/out as suggested #2340 (comment) but not worked. Will look more into it. |
I suggest adding a "discussion" action to the bottom panel that opens when you select a pin in the "Nearby" activity:
It would open an activity that could look like this:
The edit should be made with a particular edit tag, so that we can keep track of this feedback and impact the changes:
I volunteer to do that work, as I expect the workload to be bearable.
Implementing this would also solve issue #965.
Phase 2 (only after the feature above is implemented): Allow users to write a memo about the item even when offline. This would allow off-the-grid photographers with a DSLR to write down a picture filename, and later match it when they get back home.
The text was updated successfully, but these errors were encountered: