Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamp the layout of the website #28

Closed
7 tasks done
sivaraam opened this issue May 9, 2018 · 3 comments · Fixed by #38
Closed
7 tasks done

Revamp the layout of the website #28

sivaraam opened this issue May 9, 2018 · 3 comments · Fixed by #38

Comments

@sivaraam
Copy link
Member

sivaraam commented May 9, 2018 •
edited
Loading

It seems the website could use some improvements in terms of the responsiveness and with respect to the layout. Here are a few screenshots of the issue I noticed in the website:

I would like to work on this if people don't mind me working on this and if it's worth doing it.
@nicolas-raoul
Copy link
Member

Great, thanks for the feedback, looking forward to your pull request :-)
By the way, what browser were the screenshots taken with?

@sivaraam
Copy link
Member Author

By the way, what browser were the screenshots taken with?

It was taken using the "Responsive design mode" of firefox (accessed using Ctrl+Shift+M).

sivaraam added a commit to sivaraam/commons-app.github.io that referenced this issue Mar 31, 2019
@sivaraam
Use a font stack to make the text look better
0d61558 
The font stack has been borrowed from the recent font stack upgrade that
is being made to Wikipedia sites[1].

It looks a lot better that how it was before on the devices that have been
tested:

1. An Android phone
2. Firefox and Chrome on Ubuntu

This resolves an item in commons-app#28.

[1]: https://phabricator.wikimedia.org/T175877
@sivaraam sivaraam mentioned this issue Mar 31, 2019
Merged
sivaraam added a commit to sivaraam/commons-app.github.io that referenced this issue Mar 31, 2019
@sivaraam
Use a font stack to make the text look better
a32da2d 
The font stack has been borrowed from the recent font stack upgrade that
is being made to Wikipedia sites[1].

It looks a lot better that how it was before on the devices that have been
tested:

1. An Android phone
2. Firefox and Chrome on Ubuntu

This resolves an item in commons-app#28.

[1]: https://phabricator.wikimedia.org/T175877
@sivaraam sivaraam mentioned this issue Mar 31, 2019
Merged
sivaraam added a commit that referenced this issue Apr 7, 2019
@sivaraam
Merge pull request #38 from sivaraam/minor-fixes
eb865f2 
Fix for #28
@misaochan
Copy link
Member

Just wanted to say that I love the new version of the website!! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for #28 sivaraam/commons-app.github.io
3 participants
@nicolas-raoul @misaochan @sivaraam