Fix for #28 #38
Merged
Fix for #28 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The numbering of the list items seems very large when compared to the size of the list item. This results in the numbers looking a little odd. So, reduce the size of the list item numbers.
This helps save some unneeded wastage of space when showing the QR code. Only white space in the border has been trimmed no other consequence intended.
This helps save some bandwidth and helps with the quicker loading of the website possibly without losing anything else.
This helps ensure that the QR code is center aligned in smaller screens.
Grouping the buttons helps with fixing the issue that they are aligned closer to each other on smaller screens. For the same reason, the buttons are not qualified as 'btn-lg'.
This icon is just the app's icon taken from the app's source. Location of app icon: apps-android-commons/app/src/main/res/mipmap-xhdpi/ic_launcher.png Commit: 69b0f4035 (Fix #2793: Campaigns work on Beta (#2798), 2019-03-30)
This was referenced Mar 31, 2019
domdomegg
approved these changes
Apr 7, 2019
There was a problem hiding this comment.
Looks good to me.
Maybe one suggestion would be to keep the QR code as PNG as JPEG results in aliasing artifacts. Using something like tinypng will massively reduce its filesize down to less than jpeg actually, to 17KB. Ideally (maybe for the future) we could either use SVG or reconsider even it's need there.
|
In case it helps, here's the compressed png:
|
This is to avoid aliasing effect in the image as mentioned by @domdomegg.
|
Thanks a lot for the tip about using compressed PNG @domdomegg and mentioning about the drawback of JPEG. I've just replaced the JPEG version with the PNG you gave here (thanks for that too!). We'll come back to re-considering/using an SVG version it later :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes some changes to fix the issues noted in #28. Apart from that it adds a site icon which is just the app's icon as of now.
Fixes #28.