Add more tests for the English Wiktionary parser #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -366,7 +372,7 @@ def parse_structured_entry(self, structure): | |||
| print(traceback.format_exc()) | |||
| failures += 1 | |||
|
|
|||
| assert failures <= 1 | |||
| assert failures <= 1 # Why is 1 failure ok? | |||
There was a problem hiding this comment.
On the topic of "Why is 1 failure ok?": if you can get it to run with 0 failures, by all means do so.
The unpredictability of what Wiktionary throws at us has made this unachievable so far, but if a strangely-formatted entry can just quietly produce no assertions instead of breaking the parser, that would be great.
The main concern would be that a change to the code might make the failures disappear because they're "succeeding" in producing nonsense assertions. This is why unit tests are nice to have, though.
rspeer
pushed a commit
that referenced
this pull request
Jul 8, 2015
Add more tests for the English Wiktionary parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.