BUG: Fix crash in ctkDICOMQueryRetrieveWidget #1057
Conversation
|
Instead of the crash, should the user expect to the warning message ? May be worth adding a comment in the code with a link to the original issue or report documenting the crash. |
|
We'll use query-retrieve in a project, so it will get some more testing and improvements, but right now I have no more information than what is in the commit comment. I could add a ticket for the crash but this PR fixes it, so it would not help much. If added an issue for query/retrieve failing then it may be useful, but only if I had more time to do some investigation, maybe reproduce the issue - but I'm not sure when I'm going to do that. I would prefer to just integrate this as is and then later we'll make query-retrieve more robust. |
After multiple queries with different criteria, the query/retrieve widget crashed due to null-pointer dereference. It was not clear what led to the error, but the null-pointer check in this commit prevents the application from crashing, which is already an improvement.
jcfr
force-pushed
the
fix-dicom-retrieve-crash
branch
from
ca6cdfd
to
d349b87
Compare
|
I think we were both clicking at the same time @jcfr - sorry if this led to a bad state. |
|
Thanks for the review. Should now be good for integration 🚀 I will let you go ahead and merge 👌 |
After multiple queries with different criteria, the query/retrieve widget crashed due to null-pointer dereference. It was not clear what led to the error, but the null-pointer check in this commit prevents the application from crashing, which is already an improvement.