Fix regression in ctkDateRangeWidget #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesobutler
approved these changes
Jun 3, 2023
This commit fixes ctkDateRangeWidgetTest1 failure introduced in 591820e (COMP: Fix QDateTime Start and End time deprecation warning)
Following 9021b4f (Cleanup ctkDateRangeWidget), support for displaying time was introduced.
This commit fixes warings like the following:
/path/to/CTK/Libs/Widgets/Testing/Cpp/ctkDateRangeWidgetTest1.cpp:41:51: warning: ‘QDateTime::QDateTime(const QDate&)’ is deprecated: Use QDate::startOfDay() [-Wdeprecated-declarations]
41 | QDateTime today = QDateTime(QDate::currentDate());
| ^
…Widget Partially revert 591820e (COMP: Fix QDateTime Start and End time deprecation warning) removing the introduction of "startOfDay" and "endOfDay" ivars.
jamesobutler
force-pushed
the
fix-ctkDateRangeWidget-regression
branch
from
82e8b95
to
d403489
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally:
ctkDateRangeWidget::displayTimeQDateTimedeprecation warnings inctkDateRangeWidgetTest1ctkDateRangeWidget