Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in ctkDateRangeWidget #1086

Merged
merged 4 commits into from
Jun 3, 2023
Merged

Fix regression in ctkDateRangeWidget #1086

merged 4 commits into from
Jun 3, 2023

Commits on Jun 3, 2023

  1. BUG: Fix regression in ctkDateRangeWidget 

    This commit fixes ctkDateRangeWidgetTest1 failure introduced
in 591820e (COMP: Fix QDateTime Start and End time deprecation warning)
    @jcfr @jamesobutler
    jcfr authored and jamesobutler committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    a8e2fb3 View commit details
    Browse the repository at this point in the history

  2. BUG: Remove obsolete error message in ctkDateRangeWidget::displayTime 

    Following 9021b4f (Cleanup ctkDateRangeWidget), support for displaying
time was introduced.
    @jcfr @jamesobutler
    jcfr authored and jamesobutler committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    3423078 View commit details
    Browse the repository at this point in the history

  3. COMP: Fix QDateTime deprecation warnings in ctkDateRangeWidgetTest1 

    This commit fixes warings like the following:

  /path/to/CTK/Libs/Widgets/Testing/Cpp/ctkDateRangeWidgetTest1.cpp:41:51: warning: ‘QDateTime::QDateTime(const QDate&)’ is deprecated: Use QDate::startOfDay() [-Wdeprecated-declarations]
     41 |   QDateTime today = QDateTime(QDate::currentDate());
        |                                                   ^
    @jcfr @jamesobutler
    jcfr authored and jamesobutler committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    1d813c5 View commit details
    Browse the repository at this point in the history

  4. STYLE: Simplify handling of Qt4 & Qt5 API differences in ctkDateRange… 

    …Widget

Partially revert 591820e (COMP: Fix QDateTime Start and End time
deprecation warning) removing the introduction of "startOfDay" and
"endOfDay" ivars.
    @jcfr @jamesobutler
    jcfr authored and jamesobutler committed Jun 3, 2023
    Configuration menu
    Copy the full SHA
    d403489 View commit details
    Browse the repository at this point in the history