Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simple warnings #1097

Merged
merged 9 commits into from
Jun 14, 2023
Merged

Fix simple warnings #1097

merged 9 commits into from
Jun 14, 2023

Conversation

jcfr
Copy link
Member

@jcfr jcfr commented Jun 14, 2023

No description provided.

jcfr added 9 commits June 14, 2023 01:00
…Widget

This commit fixes warnings like the following:

/path/to/CTK/Libs/Widgets/ctkWorkflowButtonBoxWidget.cpp:200:72: warning: ‘static QSet<T> QSet<T>::fromList(const QList<T>&) [with T = ctkWorkflowStep*]’ is deprecated: Use QSet<T>(list.begin(), list.end()) instead. [-Wdeprecated-declarations]
  200 |     QSet<ctkWorkflowStep*>::fromList(this->GoToButtonToStepMap.values());
      |                                                                        ^
This commit fixes warnings like the following:

/path/to/CTK/Plugins/org.commontk.dah.core/ctkSoapConnectionRunnable.cpp:146:27: warning: ‘QByteArray& QByteArray::append(const QString&)’ is deprecated: Use QString's toUtf8(), toLatin1() or toLocal8Bit() [-Wdeprecated-declarations]
  146 |       block.append(content);
      |                           ^
…eSQL

This commit fixes the following warning:

/path/to/CTK/Libs/PluginFramework/ctkPluginStorageSQL.cpp:737:46: warning: ‘int QSqlError::number() const’ is deprecated [-Wdeprecated-declarations]
  737 |       int result = query->lastError().number();
      |                                              ^
This commit fixes the following warning:

/path/to/CTK/Applications/ctkCommandLineModuleExplorer/ctkCommandLineModuleExplorerMain.cpp:146:47: warning: ‘QByteArray& QByteArray::append(const QString&)’ is deprecated: Use QString's toUtf8(), toLatin1() or toLocal8Bit() [-Wdeprecated-declarations]
  146 |     byteArray.append(args["string"].toString());
      |                                               ^
This commit fixes warnings like the following:

/path/to/CTK/Libs/PluginFramework/ctkPluginStorageSQL.cpp:699:23: warning: ‘QList<T> QSet<T>::toList() const [with T = QString]’ is deprecated: Use values() instead. [-Wdeprecated-declarations]
  699 |   return paths.toList();
      |                       ^
…wser

This commit fixes the following warning:

/path/to/CTK/Libs/DICOM/Widgets/ctkDICOMBrowser.cpp:1633:45: warning: ‘QFileDialog::DirectoryOnly’ is deprecated: Use setOption(ShowDirsOnly, true) instead [-Wdeprecated-declarations]
 1633 |   directoryDialog->setFileMode(QFileDialog::DirectoryOnly);
      |                                             ^~~~~~~~~~~~~
This commit fixes warnings like the following:

/path/to/CTK/Libs/DICOM/Widgets/ctkDICOMTableView.cpp:358:49: warning: ‘void QList<T>::swap(int, int) [with T = int]’ is deprecated: Use QList<T>::swapItemsAt() [-Wdeprecated-declarations]
  358 |           columnIndicesByVisualIndex.swap(j, j+1);
      |                                                 ^
This commit fixes the following warning:

/path/to/CTK/Libs/DICOM/Widgets/Testing/Cpp/ctkDICOMBrowserTest.cpp:79:49: warning: ‘QDir& QDir::operator=(const QString&)’ is deprecated: Use QDir::setPath() instead [-Wdeprecated-declarations]
   79 |   this->DICOMDir = dataDir.filePath("Data/DICOM");
      |                                                 ^
…ogTest1

This commit fixes the following warning:

/path/to/CTK/Libs/Widgets/Testing/Cpp/ctkFileDialogTest1.cpp:47:40: warning: ‘QFileDialog::DirectoryOnly’ is deprecated: Use setOption(ShowDirsOnly, true) instead [-Wdeprecated-declarations]
   47 |   fileDialog->setFileMode(QFileDialog::DirectoryOnly);
      |                                        ^~~~~~~~~~~~~
@jcfr jcfr mentioned this pull request Jun 14, 2023
@jcfr jcfr enabled auto-merge (rebase) June 14, 2023 13:54
@jcfr jcfr merged commit 724c154 into commontk:master Jun 14, 2023
3 checks passed
@jcfr jcfr mentioned this pull request Jun 15, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant