Fix warnings #1096
Merged
Fix warnings #1096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
force-pushed
the
fix-warnings
branch
2 times, most recently
from
31f9139
to
5990704
Compare
jamesobutler
approved these changes
Jun 26, 2023
This commit fixes warnings like the following:
/path/to/CTK/Libs/DICOM/Widgets/ctkDICOMImage.cpp:122:25: warning: ‘QByteArray& QByteArray::append(const QString&)’ is deprecated: Use QString's toUtf8(), toLatin1() or toLocal8Bit() [-Wdeprecated-declarations]
122 | buffer.append(header);
| ^
/path/to/CTK/Libs/DICOM/Widgets/ctkDICOMItemView.cpp:323:25: warning: ‘QByteArray& QByteArray::append(const QString&)’ is deprecated: Use QString's toUtf8(), toLatin1() or toLocal8Bit() [-Wdeprecated-declarations]
323 | buffer.append(header);
| ^
Co-authored-by: James Butler <james.butler@perkinelmer.com>
Co-authored-by: Andras Lasso <lasso@queensu.ca>
…tView
This commit fixes the following warnings:
/path/to/CTK/Libs/Visualization/VTK/Widgets/ctkVTKAbstractView.cpp:207:26: warning: ‘void QTime::start()’ is deprecated: Use QElapsedTimer instead [-Wdeprecated-declarations]
207 | d->RequestTime.start();
| ^
/path/to/CTK/Libs/Visualization/VTK/Widgets/ctkVTKAbstractView.cpp:210:35: warning: ‘int QTime::elapsed() const’ is deprecated: Use QElapsedTimer instead [-Wdeprecated-declarations]
210 | else if (d->RequestTime.elapsed() > msecsBeforeRender)
| ^
This commit fixes the following warning:
/path/to/CTK/Libs/DICOM/Widgets/ctkDICOMThumbnailGenerator.cpp:174:23: warning: ‘QByteArray& QByteArray::append(const QString&)’ is deprecated: Use QString's toUtf8(), toLatin1() or toLocal8Bit() [-Wdeprecated-declarations]
174 | buffer.append(header);
| ^
Co-authored-by: James Butler <james.butler@perkinelmer.com>
Co-authored-by: Andras Lasso <lasso@queensu.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would appreciate a review of the fixes related to:
ctkVTKAbstractViewctkDICOMImagectkDICOMThumbnailGeneratorUpdate: This pull request now only contain the changes for which I would appreciate a review. The other ones have been moved to;