ENH: Reduce memory usage of DICOM indexer #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfr
reviewed
Oct 15, 2019
Libs/DICOM/Core/ctkDICOMDatabase.h
Outdated
| @@ -198,6 +199,13 @@ class CTK_DICOM_CORE_EXPORT ctkDICOMDatabase : public QObject | |||
| void setTagsToPrecache(const QStringList tags); | |||
| const QStringList tagsToPrecache(); | |||
|
|
|||
| /// \brief Tags that must not be stored in the tag cache. | |||
| /// Tag may be excluded from storage if it is not suitable for storage in the database or it is usually too large. | |||
There was a problem hiding this comment.
... or it is usually -> ...or if it is usually
Libs/DICOM/Core/ctkDICOMDatabase.h
Outdated
| @@ -198,6 +199,13 @@ class CTK_DICOM_CORE_EXPORT ctkDICOMDatabase : public QObject | |||
| void setTagsToPrecache(const QStringList tags); | |||
| const QStringList tagsToPrecache(); | |||
|
|
|||
| /// \brief Tags that must not be stored in the tag cache. | |||
| /// Tag may be excluded from storage if it is not suitable for storage in the database or it is usually too large. | |||
| /// Presence of non-empty tag can be still checked using instanceValueExists or fileValueExists. | |||
There was a problem hiding this comment.
can be still checked -> can be still be checked
Libs/DICOM/Core/ctkDICOMDatabase.h
Outdated
| Q_INVOKABLE QString instanceValue (const QString sopInstanceUID, const QString tag); | ||
| Q_INVOKABLE QString instanceValue (const QString sopInstanceUID, const unsigned short group, const unsigned short element); | ||
| Q_INVOKABLE QString fileValue (const QString fileName, const QString tag); | ||
| Q_INVOKABLE QString fileValue (const QString fileName, const unsigned short group, const unsigned short element); | ||
| Q_INVOKABLE bool tagToGroupElement (const QString tag, unsigned short& group, unsigned short& element); | ||
| Q_INVOKABLE QString groupElementToTag (const unsigned short& group, const unsigned short& element); | ||
|
|
||
| /// \brief Check if an element with the given attribute tag exists in the dataset and has a non-empty value. | ||
| /// @param sopInstanceUID A string with the uid for a given instance | ||
| /// (corresponding file will be found via database) |
Allow defining cached tags that are not stored in the DICOM tag cache by value. This prevents excessive memory usage and file reading for tags that are not appropriate to store in the tag cache (such as pixel data) but it is still possible to query if the tag is present. Force updating the database after a certain number of files are parsed. This limits the total memory usage, which could grew big when hundreds of thousands of files were parsed in one batch. Fixed updating existing images (identified by SOPInstanceUID) when they are loaded from a different file. Do not show all series when the browser is initially shown, as this can take significant amount of time when a large database is loaded.
lassoan
force-pushed
the
reduce-dicom-memory-usage
branch
from
0341a57
to
f91a647
Compare
|
Thank you, I've fixed the comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow defining cached tags that are not stored in the DICOM tag cache by value. This prevents excessive memory usage and file reading for tags that are not appropriate to store in the tag cache (such as pixel data) but it is still possible to query if the tag is present.
Force updating the database after a certain number of files are parsed. This limits the total memory usage, which could grew big when hundreds of thousands of files were parsed in one batch.
Do not show all series when the browser is initially shown, as this can take significant amount of time when a large database is loaded.