Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem compiling the "add-qt5-branch" with MSVC2010 #13

Closed
rdeterre opened this issue Nov 26, 2013 · 2 comments
Closed

Problem compiling the "add-qt5-branch" with MSVC2010 #13

rdeterre opened this issue Nov 26, 2013 · 2 comments

Comments

@rdeterre
Copy link

Hi,

I'm pretty sure that this issue has a lot to do with my bad understanding of CMake. I'd like to compile PythonQt with Qt5. After cloning the "add-qt5-branch", I started Cmake-gui, set the source code directory to the newly downloaded branch and pressed 'Configure'.

This returns the following error :

CMake Error in CMakeLists.txt:
  A logical block opening on the line
    C:/Users/Me/Desktop/PythonQt-add-qt5-support/CMakeLists.txt:30 (foreach)
  is not closed.

This lets me think that there may be a missing endforeach around line 33 in CMakeFile.txt, but since it is in a block of code for Qt versions less than 5, I added the following line just above the 'Build options' block to compile with Qt5 :

set(PythonQt_QT_VERSION "5")

I've only set PythonQt_wrap_QtCore to true, and the Qt5Core_DIR accordingly, and the QMake configure step now returns :

CMake Error at CMakeLists.txt:244 (qt5_wrap_ui):
  Unknown CMake command "qt5_wrap_ui".

Is there something I can do to make this work ?

Thanks

@binbao
Copy link

binbao commented Apr 25, 2014

what's your qt version? Since qt5.2, it won't use "qt5_wrap_ui", see the qt doc here: http://qt-project.org/doc/qt-5/cmake-manual.html

@jcfr
Copy link
Member

jcfr commented Feb 18, 2016

@binbao @rdeterre Just to let you know that Qt5 support has been integrated in PR #39

If you have a chance, any feedback would be appreciated.

In the mean time, I am closing this issue.

Thanks
Jc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants