-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] @cast does not work on Julia 1.11 #272
Comments
for compatibility, should we declare it as a dependency for previous Julia version as well? |
Yes, that can be done as well - without any issues, I believe. |
Perhaps a better solution is to remove the use of any REPL internals. After all, a CLI interface shouldn't need a REPL, that's kind of the whole point of a CLI interface. |
What's the status of this? For anybody coming from google, my temporary workaround is to add REPL as a dependency of my project, and then do |
Oops I forgot to tag the fix |
should be fixed now. |
@Roger-luo I'm still having this same issue on Julia 1.11-beta1 and Comonicon 1.0.7. Are you sure it's fixed? ERROR: LoadError: MethodError: no method matching doc(::typeof(BinBencher.bench))
The function `doc` exists, but no method is defined for this combination of argument types.
Stacktrace:
[1] split_docstring(f::Function)
@ Comonicon ~/.julia/packages/Comonicon/keaqT/src/frontend/markdown.jl:11
[2] cast(f::Function, name::String, args::Vector{Comonicon.JLArgument}, options::Vector{Comonicon.JLOption}, flags::Vector{Comonicon.JLFlag}, line::LineNumberNode)
@ Comonicon ~/.julia/packages/Comonicon/keaqT/src/frontend/cast.jl:571
[3] top-level scope
@ ~/.julia/packages/Comonicon/keaqT/src/frontend/cast.jl:419
[4] include(mod::Module, _path::String)
@ Base ./Base.jl:558
[5] include(x::String)
@ BinBencher ~/code/BinBencher.jl/src/BinBencher.jl:1
[6] top-level scope
@ ~/code/BinBencher.jl/src/BinBencher.jl:25
[7] include
@ ./Base.jl:558 [inlined] And the loaded dependencies:
|
During precompilation, I get
This happens because Comonicon uses
Base.Docs.doc
, whose methods are defined in REPL, which is not loaded during precompilation on 1.11 (because REPL is not loaded, as it has been moved out of the systemimage).The solution is to declare REPL a dependency of Comonicon.
The text was updated successfully, but these errors were encountered: