Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for Lexer and Parser classes #1

Closed
comp-phys-marc opened this issue Feb 6, 2022 · 2 comments
Closed

Tests for Lexer and Parser classes #1

comp-phys-marc opened this issue Feb 6, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@comp-phys-marc
Copy link
Owner

comp-phys-marc commented Feb 6, 2022 •
edited
Loading

This package previously had a test suite that was based on the now-outdated conformance test suite specified by OpenQASM here. I would love help to write a test suite like the one in qmasm-ts here that covers the features of the language, to start. It would be great to then expand further to individually unittest the methods of the lexer and parser classes.
@comp-phys-marc comp-phys-marc added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Feb 6, 2022
@comp-phys-marc
Copy link
Owner Author

comp-phys-marc commented Feb 7, 2022 •
edited
Loading

Updated smoke tests may take inspiration from the OpenQASM 2.0 tests, some of which are preserved in the feature/v2.0specs branch.

@seankim658
Copy link
Collaborator

seankim658 commented Sep 13, 2024 •
edited
Loading

Was running some OpenQASM 2.0 tests from the old features/v2.0specs branch to make sure no backwards compatibility was broken while adding new features and found this bug. The lexer was lexing Creg declarations to QReg tokens here. This has been fixed in the openqasm-3.0 branch but just making a note of it as the test snapshots will have to be updated when they are eventually ported over.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@seankim658 @comp-phys-marc