Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model.destroy_all might not destroy all #19

Closed
trym opened this issue Jan 25, 2011 · 2 comments
Closed

Model.destroy_all might not destroy all #19

trym opened this issue Jan 25, 2011 · 2 comments

Comments

@trym
Copy link

trym commented Jan 25, 2011

After doing Update.destroy_all I had one update left, which went away when I did Update.destroy_all again.

@thhermansen
Copy link
Contributor

Don't think this is related to the ORM, as the implementation of destroy_all is really easy (https://github.com/CompanyBook/massive_record/blob/develop/lib/massive_record/orm/persistence.rb)

I think this actually is a wrapper (adapter) problem, as the Scanner applies a default limit of 10: https://github.com/CompanyBook/massive_record/blob/develop/lib/massive_record/wrapper/scanner.rb. Now that's a problem meaning that all will just return 10 and not all .. which should really be corrected.

@thhermansen
Copy link
Contributor

Kinda fixed in 4d23ad8

Maybe we should look at it a bit more later...

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants