-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use nodemailer for sending email (with local email dev solution) #433
Conversation
…ransport mechanisms.
Hm. Worked locally, but something happening when running on GitHub Actions, and cy.visit is getting confused... Will investigate later. |
adf9ab0
to
e2da854
Compare
For later, apparently maildev has a restful API, so we can be hitting that instead of parsing an html page, as recommended by cypress best-practices. https://github.com/maildev/maildev/blob/master/docs/rest.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks great. I have one concern only, in changing the table name.
Thanks so much for the review @ballPointPenguin! Good call on figuring out migrations. I'll do that in this PR then bring it out of draft |
This is now |
Hm. Not sure why e2e tests aren't running... seems to have stopped in cca71ac |
93537e3
to
b51ba07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
…pdemocracy#433) * Updated database schema to bugfix password reset process. [Fixes compdemocracy#273] * Added maildev docker container for inspecting emails during dev. * Ensured the proxied services are seeing the origin host. * Small fixup from rebase. * Added SMTP port exposure to maildev container. * Migrated AWS_REGION config into envvar. * Added mailgun nodemailer transport. Added fallback through multiple transport mechanisms. * Added ability for cypress to check maildev inbox on another port. * e2e: Fixed create_user test. * e2e: Added checks of password reset flow. * e2e: Added test stubs for types of emails sent. * e2e: Run through whole password reset flow, and confirm new password. * e2e: Added plugin to output more details to stdout. * e2e: Make more clear when reporter prints to terminal. * Added log command for troubleshooting GitHub Actions issue. * e2e: Fixed issue with matching password reset token. * Added testing of email transport failover. * Adding docs for email transport configuration. [skip ci] * Check maildev via API instead of UI. * Improved documentation of cypress workflow for email transports. * e2e: Added note about cypress-terminal-report in README. * Removed straggling TODO. * Set email transport defaults to match current production.
…pdemocracy#433) * Updated database schema to bugfix password reset process. [Fixes compdemocracy#273] * Added maildev docker container for inspecting emails during dev. * Ensured the proxied services are seeing the origin host. * Small fixup from rebase. * Added SMTP port exposure to maildev container. * Migrated AWS_REGION config into envvar. * Added mailgun nodemailer transport. Added fallback through multiple transport mechanisms. * Added ability for cypress to check maildev inbox on another port. * e2e: Fixed create_user test. * e2e: Added checks of password reset flow. * e2e: Added test stubs for types of emails sent. * e2e: Run through whole password reset flow, and confirm new password. * e2e: Added plugin to output more details to stdout. * e2e: Make more clear when reporter prints to terminal. * Added log command for troubleshooting GitHub Actions issue. * e2e: Fixed issue with matching password reset token. * Added testing of email transport failover. * Adding docs for email transport configuration. [skip ci] * Check maildev via API instead of UI. * Improved documentation of cypress workflow for email transports. * e2e: Added note about cypress-terminal-report in README. * Removed straggling TODO. * Set email transport defaults to match current production.
Addresses #231
Should be working, but need to write tests before I seek full review. But I'm still looking for feedback on the approach I've taken :)
To Do
fix issue withmoved to Add support for proper database migrations (fix pwreset table) #542pwreset_tokens
database table being named improperlyother e2e tests to consider adding in future:
broken
(see: Conversation data export not working via UI #39)