Password reset fails to save reset tokens to database #273
Labels
Comments
|
Oh, and I've confirmed that fixing this allows passwords to be reset correctly 🎉 |
patcon
referenced
this issue
in patcon/polis
Jun 6, 2020
patcon
referenced
this issue
in patcon/polis
Jun 6, 2020
patcon
referenced
this issue
in patcon/polis
Jul 17, 2020
|
This will be resolved by #433 |
15 tasks
|
Closing as dup of #216 |
patcon
added a commit
that referenced
this issue
Aug 22, 2020
* Updated database schema to bugfix password reset process. [Fixes #273] * Added maildev docker container for inspecting emails during dev. * Ensured the proxied services are seeing the origin host. * Small fixup from rebase. * Added SMTP port exposure to maildev container. * Migrated AWS_REGION config into envvar. * Added mailgun nodemailer transport. Added fallback through multiple transport mechanisms. * Added ability for cypress to check maildev inbox on another port. * e2e: Fixed create_user test. * e2e: Added checks of password reset flow. * e2e: Added test stubs for types of emails sent. * e2e: Run through whole password reset flow, and confirm new password. * e2e: Added plugin to output more details to stdout. * e2e: Make more clear when reporter prints to terminal. * Added log command for troubleshooting GitHub Actions issue. * e2e: Fixed issue with matching password reset token. * Added testing of email transport failover. * Adding docs for email transport configuration. [skip ci] * Check maildev via API instead of UI. * Improved documentation of cypress workflow for email transports. * e2e: Added note about cypress-terminal-report in README. * Removed straggling TODO. * Set email transport defaults to match current production.
raulsperoni
pushed a commit
to proyectourgente/polis
that referenced
this issue
Sep 1, 2021
…pdemocracy#433) * Updated database schema to bugfix password reset process. [Fixes compdemocracy#273] * Added maildev docker container for inspecting emails during dev. * Ensured the proxied services are seeing the origin host. * Small fixup from rebase. * Added SMTP port exposure to maildev container. * Migrated AWS_REGION config into envvar. * Added mailgun nodemailer transport. Added fallback through multiple transport mechanisms. * Added ability for cypress to check maildev inbox on another port. * e2e: Fixed create_user test. * e2e: Added checks of password reset flow. * e2e: Added test stubs for types of emails sent. * e2e: Run through whole password reset flow, and confirm new password. * e2e: Added plugin to output more details to stdout. * e2e: Make more clear when reporter prints to terminal. * Added log command for troubleshooting GitHub Actions issue. * e2e: Fixed issue with matching password reset token. * Added testing of email transport failover. * Adding docs for email transport configuration. [skip ci] * Check maildev via API instead of UI. * Improved documentation of cypress workflow for email transports. * e2e: Added note about cypress-terminal-report in README. * Removed straggling TODO. * Set email transport defaults to match current production.
raulsperoni
pushed a commit
to proyectourgente/polis
that referenced
this issue
Oct 26, 2021
…pdemocracy#433) * Updated database schema to bugfix password reset process. [Fixes compdemocracy#273] * Added maildev docker container for inspecting emails during dev. * Ensured the proxied services are seeing the origin host. * Small fixup from rebase. * Added SMTP port exposure to maildev container. * Migrated AWS_REGION config into envvar. * Added mailgun nodemailer transport. Added fallback through multiple transport mechanisms. * Added ability for cypress to check maildev inbox on another port. * e2e: Fixed create_user test. * e2e: Added checks of password reset flow. * e2e: Added test stubs for types of emails sent. * e2e: Run through whole password reset flow, and confirm new password. * e2e: Added plugin to output more details to stdout. * e2e: Make more clear when reporter prints to terminal. * Added log command for troubleshooting GitHub Actions issue. * e2e: Fixed issue with matching password reset token. * Added testing of email transport failover. * Adding docs for email transport configuration. [skip ci] * Check maildev via API instead of UI. * Improved documentation of cypress workflow for email transports. * e2e: Added note about cypress-terminal-report in README. * Removed straggling TODO. * Set email transport defaults to match current production.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After submitted a password reset request, was getting emails that looked like this:
Managed to track it down to the create database table not match the read/write queries:
https://github.com/pol-is/polisServer/blob/5ac29b7245a7b198e40d1727ea246ed25acfecb7/server/postgres/db_setup_draft.sql#L338-L343
https://github.com/pol-is/polisServer/blob/5ac29b7245a7b198e40d1727ea246ed25acfecb7/server/server.js#L852
https://github.com/pol-is/polisServer/blob/5ac29b7245a7b198e40d1727ea246ed25acfecb7/server/server.js#L863
https://github.com/pol-is/polisServer/blob/5ac29b7245a7b198e40d1727ea246ed25acfecb7/server/server.js#L881
@pol-is/core lemme know which form of the database table you'd prefer to use, and I'll submit a PR :)
cc: @urakagi assuming you use the
local-polisbranch, this seems to affect the PDIS fork as well, so you might want to investigate.The text was updated successfully, but these errors were encountered: