Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for proper database migrations (fix pwreset table) #542

Merged
merged 4 commits into from
Aug 21, 2020
Merged

Add support for proper database migrations (fix pwreset table) #542

merged 4 commits into from
Aug 21, 2020

Conversation

patcon
Copy link
Contributor

@patcon patcon commented Aug 18, 2020

Re-ticketed from #433 (comment)

This does the following:

  • Moves and renames SQL files to keep "active" migrations separate.
  • Exercises migrations on fresh database initialization.
  • Adds docs for how to manually apply migrations if you already have a database.

@patcon patcon added 🔩 p:server ⚒️ infrastructure Re: automation, continuous integration. labels Aug 18, 2020
@patcon patcon requested review from metasoarous and a team as code owners August 18, 2020 18:33
@patcon patcon self-assigned this Aug 18, 2020
@patcon patcon added this to In progress in Polis development via automation Aug 18, 2020
@patcon patcon changed the title Add support for proper database migrations Add support for proper database migrations (fix pwreset table) Aug 21, 2020
metasoarous
metasoarous approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@metasoarous metasoarous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@patcon patcon merged commit a077387 into dev Aug 21, 2020
Polis development automation moved this from In progress to Done Aug 21, 2020
@patcon patcon deleted the db-migrations branch August 21, 2020 18:42
@metasoarous metasoarous removed this from Done in Polis development Feb 25, 2021
raulsperoni pushed a commit to proyectourgente/polis that referenced this pull request Sep 1, 2021
@patcon
Add support for proper database migrations (fix pwreset table) (compd…
eb28c5e 
…emocracy#542)

* Removed empty script file.

* Reorganized files for easier database migrations. Documented manual migrations.

* Improved inline comment for db init.

* Added disclaimer about backups.
raulsperoni pushed a commit to proyectourgente/polis that referenced this pull request Oct 26, 2021
@patcon
Add support for proper database migrations (fix pwreset table) (compd…
3b31ed4 
…emocracy#542)

* Removed empty script file.

* Reorganized files for easier database migrations. Documented manual migrations.

* Improved inline comment for db init.

* Added disclaimer about backups.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ballPointPenguin ballPointPenguin ballPointPenguin approved these changes

@metasoarous metasoarous metasoarous approved these changes

Assignees

@patcon patcon

Labels
⚒️ infrastructure Re: automation, continuous integration. 🔩 p:server
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@patcon @ballPointPenguin @metasoarous