This repository has been archived by the owner on Mar 27, 2019. It is now read-only.
Splitting path correctly on Windows #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@timaschew I think we should merge this one in before a 1.0 release. This is just a good idea in general. I checked through the rest of the codebase and didn't find any other occurrences of splitting on ":" so this should solve the problem global. Thanks for this pull request! Nice catch! |
timaschew
added a commit
that referenced
this pull request
Sep 15, 2014
Splitting path correctly on Windows
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
component tscon Windows fails with the error messagecomponent-tsc(1) does not exist.This is because it splits the PATH on
:which doesn't work well with;separated paths beginningC:The fix to make this portable on different operating systems is to just use
path.delimiter