improve search performance #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
each toggle() of a package triggers a render of the browser content, to reduce the number of renders, we hide the element containing all packages during the filtering
|
the satis at http://packages.firegento.com/ now include this changes, so you can test them there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
each toggle() of a package triggers a render of the browser content,
to reduce the number of renders, we hide the element containing all
packages during the filtering.
with the big number of packages we have at http://packages.firegento.com/ a search can need >30s.
JS profiling showed, the JS is only busy ~2-3s and idles during the rest.
with this patch the rendering time for a search was reduced to just a few seconds.