OpenSSL issue when compiling on NetBSD #143

martintc · 2022-03-11T04:58:17Z

I am working on trying to port comtrya over to NetBSD and ran into an initial issue in the build process. Look like it has an issue with the vendored version of openssl.

Here is the output:

error: failed to run custom build command for `openssl-sys v0.9.72`

Caused by:
  process didn't exit successfully: `/home/todd/Projects/comtrya/target/debug/build/openssl-sys-dede6734a7187c76/build-script-main` (exit status: 101)
  --- stdout
  cargo:rustc-cfg=const_fn
  cargo:rerun-if-env-changed=X86_64_UNKNOWN_NETBSD_OPENSSL_NO_VENDOR
  X86_64_UNKNOWN_NETBSD_OPENSSL_NO_VENDOR unset
  cargo:rerun-if-env-changed=OPENSSL_NO_VENDOR
  OPENSSL_NO_VENDOR unset
  CC_x86_64-unknown-netbsd = None
  CC_x86_64_unknown_netbsd = None
  HOST_CC = None
  CC = None
  CFLAGS_x86_64-unknown-netbsd = None
  CFLAGS_x86_64_unknown_netbsd = None
  HOST_CFLAGS = None
  CFLAGS = None
  CRATE_CC_NO_DEFAULTS = None
  DEBUG = Some("true")
  CARGO_CFG_TARGET_FEATURE = Some("fxsr,sse,sse2")
  running "perl" "./Configure" "--prefix=/home/todd/Projects/comtrya/target/debug/build/openssl-sys-235ad40d71f59b42/out/openssl-build/install" "no-dso" "no-shared" "no-ssl3" "no-unit-test" "no-comp" "no-zlib" "no-zlib-dynamic" "no-md2" "no-rc5" "no-weak-ssl-ciphers" "no-camellia" "no-idea" "no-seed" "BSD-x86_64" "-O2" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-m64"
  Configuring OpenSSL version 1.1.1m (0x101010dfL) for BSD-x86_64
  Using os-specific seed configuration
  Creating configdata.pm
  Creating Makefile

  **********************************************************************
  ***                                                                ***
  ***   OpenSSL has been successfully configured                     ***
  ***                                                                ***
  ***   If you encounter a problem while building, please open an    ***
  ***   issue on GitHub <https://github.com/openssl/openssl/issues>  ***
  ***   and include the output from the following command:           ***
  ***                                                                ***
  ***       perl configdata.pm --dump                                ***
  ***                                                                ***
  ***   (If you are new to OpenSSL, you might want to consult the    ***
  ***   'Troubleshooting' section in the INSTALL file first)         ***
  ***                                                                ***
  **********************************************************************
  running "make" "depend"
  running "make" "build_libs"

  --- stderr
  make: illegal argument to -j -- must be positive integer!
  thread 'main' panicked at '


  Error building OpenSSL:
      Command: "make" "build_libs"
      Exit status: exit status: 1


      ', /home/todd/.cargo/registry/src/github.com-1ecc6299db9ec823/openssl-src-111.17.0+1.1.1m/src/lib.rs:479:13
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...
error: build failed

OS: NetBSD 9.2
Arch: Amd64

I have also opened an issue on OpenSSL's github.

The text was updated successfully, but these errors were encountered:

kraileth · 2022-03-12T07:00:37Z

This has been the case for me as well. I could only ever get Comtrya built on FreeBSD by first editing Cargo.toml and removing the "vendored" feature from the openssl crate. Doing so resulted in a Comtrya binary that worked for me, however I have no idea what side effects it may cause (e.g. I have only ever used local manifests). Would be interesting to know the rationale for defining it this way in the first place and what a proper solution might be.

I don't remember entirely why this was set to vendored, but I seem to recall it was when I added remote manifest support with Git. Sadly, comtrya#143 does seem to indicate this causes issues on BSD systems. Let's try without and see what breaks

rawkode · 2022-03-12T08:13:47Z

Let's see what happens if I remove it 😮 #144

rawkode · 2022-03-12T08:31:03Z

OK. Looks like this was a problem because Windows doesn't have a system level OpenSSL to build with. I've told Cargo to only vendor on Windows.

I hope this helps. Should be merged when the tests pass.

I don't remember entirely why this was set to vendored, but I seem to recall it was when I added remote manifest support with Git. Sadly, #143 does seem to indicate this causes issues on BSD systems. Let's try without and see what breaks

rawkode · 2022-03-12T08:37:29Z

This fix has been merged to main. Going to close this issue, but please feel free to reopen if there are any further problems.

martintc · 2022-03-12T09:28:38Z

Sounds good, thanks! Kraileth had mentioned this to me over email and it worked. I hit another issue, but I don't think it is comtrya specific but mostly how NetBSD handled the shared object library for libssl.

rawkode · 2022-03-12T09:36:45Z

Earlier versions of Comtrya tried to avoid OpenSSL altogether by using ring, but it was rather unstable. I'll try again on Monday.

martintc · 2022-03-12T10:35:55Z

If you just want a reference from NetBSD, here is the terminal output. It compiles with not using the vendored version of openssl. But it hits a runtime issue.

The warning is for an import I have not started using yet that I will be using in the pkgin package provider to set everything up for the boostrap.

rawkode · 2022-03-12T10:45:37Z

What does locate libssl.so return?

I may need to try and get a NetBSD VM running to test this myself, but one of the goals of Comtrya is to run everywhere; so I'm happy to help get this working

kraileth · 2022-03-12T10:51:35Z

@martintc This is interesting. Are you building with Cargo.toml as is after the recent fix or did you modify anything?

At least for me on FreeBSD this does not work for some reason. I need to comment out the line openssl = { version = "0.10", features = ["vendored"] } even though it should only apply to windows.. Tried out replacing [target.'cfg(windows)'.dependencies] with [target.'cfg(target_os = "windows")'.dependencies] which I found mentioned on the net, placed the unix part before it and such - with no success so far.

Now FreeBSD certainly isn't Windows and I'm not sure what's going on with cargo there. Would be interesting to know if it works as intended on NetBSD.

rawkode · 2022-03-12T10:54:29Z

Damn, that's frustrating @kraileth. I'm going to need to dig in to this further. I am really surprised Cargo didn't respect that import definition

kraileth · 2022-03-12T11:02:50Z

@rawkode I can offer you SSH access to a FreeBSD jail and a NetBSD VM with Rust and Git installed if it helps. Just drop me a mail with a public key if you want me to provide the two dev systems.

martintc · 2022-03-12T11:07:05Z

@kraileth and @rawkode

This is with the adjustment to Cargo.toml to removing the vendored version and just using openssl = '0.10'

What is look like is the linker is finding libssl.so.14 when it expects libssl.so.1.1. At least that was the jist I got from a chain of emails in the NetBSD mailing list. Looks like this issue was hit with firefox on NetBSD since firefox uses a lot of Rust code. One possible solution I saw was changing the path in the BSD Makefile in pkgsrc to help comtry/rust find the appropriate libssl during the linking phase.

Email from NetBSD mailing list

To see any changes to my fork for working on NetBSD

My working branch for NetBSD

martintc · 2022-03-12T11:16:09Z

Huh, interesting. I pulled the recent change from main into my NetBSD branch and yea, Cargo doesn't seem to be respecting the [target.cfg(unix).dependencies] so current it does not compile. I will probably revert that back.

Have removed those lines from my NetBSD branch. So now that branch compiles without error on NetBSD.

rawkode · 2022-03-12T13:41:39Z

@kraileth I've dropped it to you via Discord.

rawkode · 2022-03-12T13:50:24Z

@martintc I've removed openssl in this PR #145

OpenSSL is actually a transitive dependency, so I don't actually need to list it.

I don't think this will help, but if you could test and let me know.

martintc · 2022-03-13T01:50:31Z

@martintc I've removed openssl in this PR #145

OpenSSL is actually a transitive dependency, so I don't actually need to list it.

I don't think this will help, but if you could test and let me know.

Will do. I will give it a shot tonight on my lunch break and let you know

martintc · 2022-03-13T08:16:57Z

@rawkode PR#145 builds successfully on NetBSD 9.2. Now, we just need to solve the missing libssl.so.1.1 issue.

rawkode · 2022-03-13T08:25:02Z

Ah. So it still won't run? Ok. I'll keep reading

martintc · 2022-03-13T08:26:45Z

Something I will test when I get a chance.

Looks like I have the library, it is just a matter of finding it during runtime. Looking at the cargo book (still newish to Rust), we may be able to link that library in during compile time like so:

cargo:rustc-link-lib=dylib=/usr/pkg/lib/libssl.so.1.1

Only issue I see here is that since it is located in /usr/pkg/lib this will require for pkgin to be bootstrapped before using comtrya. That is assuming it is a runtime dependency and not a compile time dependency.

Or something like this:

[target.x86_64-unknown-linux-gnu.foo]
rustc-link-search = ["/path/to/foo"]
rustc-link-lib = ["foo"]
root = "/path/to/foo"
key = "value"

With the appropriate paths needed.

rawkode · 2022-03-13T08:33:55Z

@kraileth @martintc I just built Comtrya without openssl on a netbsd box provider by @kraileth and it worked, no libssl.so.1.1 issue

rawkode · 2022-03-13T08:37:54Z

In the FreeBSD jail and the netbsd machine, I can successfully run:

cargo run -- https://github.com/comtrya/comtrya#main:examples

from the build of PR #145

rawkode · 2022-03-13T08:51:55Z

@kraileth thanks for that jail, found another bug that's an easy fix 😀

#146

martintc · 2022-03-13T09:09:53Z

Mhmm, wonder if it is because I wasn't providing options. Just
'Cargo run'

Awesome! I'll get to work on a package provider for pkgin then!

rawkode · 2022-03-13T09:11:40Z

Best of luck. Feel free to jump on the Discord if you need any help or advice.

https://Rawkode.chat

There's a Comtrya channel 😀

martintc · 2022-03-13T10:06:55Z

@rawkode Sounds good, I have joined the discord.

martintc · 2022-03-15T13:37:32Z

Pulled in the most recent changes in main into my development test and have been trying to run the examples/command/run.yaml and I am still getting the same issue.

CODE_OF_CONDUCT.md  Comtrya.gif         README.md           src
Cargo.lock          Justfile            deny.toml           target
Cargo.toml          LICENSE             examples            tests
localhost$ cargo run -- . -m examples/command/run.yaml
    Finished dev [unoptimized + debuginfo] target(s) in 0.64s
     Running `target/debug/comtrya . -m examples/command/run.yaml`
target/debug/comtrya: Shared object "libcrypto.so.1.1" not found
localhost$ cargo run -- --help
    Finished dev [unoptimized + debuginfo] target(s) in 0.56s
     Running `target/debug/comtrya --help`
target/debug/comtrya: Shared object "libcrypto.so.1.1" not found
localhost$ cargo run -- --manifests examples/command/run.yaml
    Finished dev [unoptimized + debuginfo] target(s) in 0.57s
     Running `target/debug/comtrya --manifests examples/command/run.yaml`
target/debug/comtrya: Shared object "libcrypto.so.1.1" not found
localhost$ cargo run -- examples/command/run.yaml
    Finished dev [unoptimized + debuginfo] target(s) in 0.55s
     Running `target/debug/comtrya examples/command/run.yaml`
target/debug/comtrya: Shared object "libcrypto.so.1.1" not found
localhost$ cargo run -- ./examples/command/run.yaml
    Finished dev [unoptimized + debuginfo] target(s) in 0.58s
     Running `target/debug/comtrya ./examples/command/run.yaml`
target/debug/comtrya: Shared object "libcrypto.so.1.1" not found

localhost$ cargo run -- https://github.com/comtrya/comtrya#main:examples
    Finished dev [unoptimized + debuginfo] target(s) in 0.65s
     Running `target/debug/comtrya 'https://github.com/comtrya/comtrya#main:examples'`
target/debug/comtrya: Shared object "libcrypto.so.1.1" not found

Well, it is slightly different now. Instead of complaining of libssl is not complains of libcrypto

rawkode · 2022-03-15T15:09:33Z

Hmm. I wonder what's different about your netbsd box vs the VM @kraileth provided?

martintc · 2022-03-16T08:15:24Z

Hmm. I wonder what's different about your netbsd box vs the VM @kraileth provided?

Are you using doas or sudo when when running?

theowenyoung · 2022-06-20T05:49:52Z

For, in a new macOS, run the binary:

 ./comtrya-x86_64-apple-darwin 
dyld[10842]: Library not loaded: /usr/local/opt/openssl@1.1/lib/libssl.1.1.dylib
  Referenced from: /Users/green/dotfiles/comtrya-x86_64-apple-darwin
  Reason: tried: '/usr/local/opt/openssl@1.1/lib/libssl.1.1.dylib' (no such file), '/usr/local/lib/libssl.1.1.dylib' (no such file), '/usr/lib/libssl.1.1.dylib' (no such file)
zsh: abort      ./comtrya-x86_64-apple-darwin

rawkode mentioned this issue Mar 12, 2022

fix: removed vendored openssl #144

Merged

rawkode closed this as completed Mar 12, 2022

rawkode reopened this Mar 12, 2022

rawkode mentioned this issue Mar 13, 2022

fix: attempt to remove openssl, as it's not a direct dependency #145

Merged

rawkode closed this as completed in #145 Mar 13, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OpenSSL issue when compiling on NetBSD #143

OpenSSL issue when compiling on NetBSD #143

martintc commented Mar 11, 2022 •

edited

Loading

kraileth commented Mar 12, 2022

rawkode commented Mar 12, 2022

rawkode commented Mar 12, 2022

rawkode commented Mar 12, 2022

martintc commented Mar 12, 2022

rawkode commented Mar 12, 2022

martintc commented Mar 12, 2022 •

edited

Loading

rawkode commented Mar 12, 2022

kraileth commented Mar 12, 2022 •

edited

Loading

rawkode commented Mar 12, 2022

kraileth commented Mar 12, 2022

martintc commented Mar 12, 2022 •

edited

Loading

martintc commented Mar 12, 2022 •

edited

Loading

rawkode commented Mar 12, 2022

rawkode commented Mar 12, 2022

martintc commented Mar 13, 2022

martintc commented Mar 13, 2022

rawkode commented Mar 13, 2022

martintc commented Mar 13, 2022 •

edited

Loading

rawkode commented Mar 13, 2022

rawkode commented Mar 13, 2022

rawkode commented Mar 13, 2022

martintc commented Mar 13, 2022

rawkode commented Mar 13, 2022

martintc commented Mar 13, 2022

martintc commented Mar 15, 2022 •

edited

Loading

rawkode commented Mar 15, 2022

martintc commented Mar 16, 2022

theowenyoung commented Jun 20, 2022

OpenSSL issue when compiling on NetBSD #143

OpenSSL issue when compiling on NetBSD #143

Comments

martintc commented Mar 11, 2022 • edited Loading

kraileth commented Mar 12, 2022

rawkode commented Mar 12, 2022

rawkode commented Mar 12, 2022

rawkode commented Mar 12, 2022

martintc commented Mar 12, 2022

rawkode commented Mar 12, 2022

martintc commented Mar 12, 2022 • edited Loading

rawkode commented Mar 12, 2022

kraileth commented Mar 12, 2022 • edited Loading

rawkode commented Mar 12, 2022

kraileth commented Mar 12, 2022

martintc commented Mar 12, 2022 • edited Loading

martintc commented Mar 12, 2022 • edited Loading

rawkode commented Mar 12, 2022

rawkode commented Mar 12, 2022

martintc commented Mar 13, 2022

martintc commented Mar 13, 2022

rawkode commented Mar 13, 2022

martintc commented Mar 13, 2022 • edited Loading

rawkode commented Mar 13, 2022

rawkode commented Mar 13, 2022

rawkode commented Mar 13, 2022

martintc commented Mar 13, 2022

rawkode commented Mar 13, 2022

martintc commented Mar 13, 2022

martintc commented Mar 15, 2022 • edited Loading

rawkode commented Mar 15, 2022

martintc commented Mar 16, 2022

theowenyoung commented Jun 20, 2022

martintc commented Mar 11, 2022 •

edited

Loading

martintc commented Mar 12, 2022 •

edited

Loading

kraileth commented Mar 12, 2022 •

edited

Loading

martintc commented Mar 12, 2022 •

edited

Loading

martintc commented Mar 12, 2022 •

edited

Loading

martintc commented Mar 13, 2022 •

edited

Loading

martintc commented Mar 15, 2022 •

edited

Loading