fix: removed vendored openssl #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't remember entirely why this was set to vendored, but I seem to recall it was when I added remote manifest support with Git. Sadly, comtrya#143 does seem to indicate this causes issues on BSD systems. Let's try without and see what breaks
Windows doesn't have a system version of OpenSSL available
Codecov Report
@@ Coverage Diff @@
## main #144 +/- ##
==========================================
+ Coverage 41.88% 44.83% +2.94%
==========================================
Files 45 43 -2
Lines 1645 1539 -106
==========================================
+ Hits 689 690 +1
+ Misses 956 849 -107
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't remember entirely why this was set to vendored, but I seem to recall it was when I added remote manifest support with Git. Sadly, #143 does seem to indicate this causes issues on BSD systems.
Let's try without and see what breaks