Implement Feature/rdf #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also added 5f47bfd and later, might be good to check those in isolation. |
1 task
joachimvh
reviewed
Nov 3, 2017
There was a problem hiding this comment.
Got this running so I assume it's fine. Didn't manage to do the whole curl streaming into the application due to the whole having to set NODE_PATH variable also.
I also don't think it's really feasible to do a full code review of everything. There's so much boilerplate stuff (e.g. the jsonld files, the similar interfaces, etc.) making it hard to see the actual relevant parts to look at :|
| export class ActorInitRdfParse extends ActorInit implements IActorInitRdfParseArgs { | ||
|
|
||
| public readonly mediatorRdfParse: Mediator<Actor<IActionRdfParseOrMediaType, IActorTest, | ||
| IActorOutputRdfParseOrMediaType>, IActionRdfParseOrMediaType, IActorTest, IActorOutputRdfParseOrMediaType>; |
| "no-var-requires": false, | ||
| "no-unused-expression": false | ||
| } | ||
| } |
There was a problem hiding this comment.
Most files have this apparently, will fix once this is merged.
Related to rdfjs/N3.js#120
rubensworks
force-pushed
the
feature/rdf
branch
from
196325a
to
8c9a671
Compare
jitsedesmet
pushed a commit
to jitsedesmet/comunica
that referenced
this pull request
Aug 8, 2023
jitsedesmet
pushed a commit
to jitsedesmet/comunica
that referenced
this pull request
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages related to RDF parsing