Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages now reference their own node_modules #13

Closed
wants to merge 1 commit into from

Conversation

joachimvh
Copy link
Member

Lerna actually creates node_modules folder for every separate package.
Referencing those makes sure the packages can still stand on their own.
(And also fixes the Windows path problem).

Lerna actually creates node_modules folder for every separate package.
Referencing those makes sure the packages can still stand on their own.
(And also fixes the Windows path problem).
@joachimvh
Copy link
Member Author

This is for issue #1. I'm actually not a 100% sure yet I don't break anything with this since I can't get the whole system running yet but I think this might be an unrelated problem. :D

@joachimvh
Copy link
Member Author

Update: got it working so I assume this is no problem

@joachimvh joachimvh mentioned this pull request Oct 30, 2017
@joachimvh
Copy link
Member Author

So I'm actually having issues making this same solution work on #4 . Not sure why yet, but after running install not all packages get their node_modules folder, so either Lerna doesn't work like I thought it did or something else is wrong.

@rubensworks
Copy link
Member

This will not work unfortunately, because tslint and jest are only dev dependencies of the root project. (Something I wouldn't change because this would result in a lot of overhead if this is stored inside the node_modules of every package)

Lerna only links the dev dependencies that are present as Lerna packages, so in this case all the @comunica/* stuff.

@joachimvh joachimvh closed this Nov 2, 2017
@joachimvh joachimvh deleted the fix/script-paths branch November 2, 2017 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants