-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rapidjson: fix cmake_find_package{,_multi} names #1180
Conversation
All green in build 1 (
|
@@ -24,3 +24,7 @@ def package(self): | |||
|
|||
def package_id(self): | |||
self.info.header_only() | |||
|
|||
def package_info(self): | |||
self.cpp_info.names["cmake_find_package"] = "RapidJSON" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this break current dependence that are using rapidjson
?
The alternate name
But it's not very clear if it replaces the default package name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running grep -Irn rapidjson | grep -i requires
on current master returns no matches.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This indeed might break external recipes, but the cmake script of rapidjson also uses RapidJSON
as cmake name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the external dependencies that I had in mind. I agree is should make the original of the project.
I take it from your reply is does indeed replace the default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a heads up, this does indeed break external dependencies. For anyone finding this with a search you'll likely need to change the casing to
|
@toshi38 The author uses the name RapidJSON: https://github.com/Tencent/rapidjson/blob/master/RapidJSONConfig.cmake.in If any other project requires rapidjsonConfig.make, it needs to be updated. |
Specify library name and version: rapidjson/1.1.0
conan-center hook activated.