Add arrow/1.0.0 recipe #1182

madebr · 2020-03-24T20:27:56Z

Specify library name and version: arrow/0.16.0

Depends on #1179
Depends on #1180
Depends on #1181
Depends on #1146

Fixes #63

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

conan-center-bot · 2020-03-24T20:34:19Z

All green in build 1 (8e723f5bb98a986e204c2c37299e619954ea413c)! 😊

arrow/0.16.0: Generated 0 packages. All logs here

conan-center-bot · 2020-03-25T00:05:48Z

Failure in build 2 (f22909009e61dfd3bb0796e85e180767e1090bb9):
arrow/0.16.0:

Error processing recipe: Linux x86_64, Release, gcc 5, libstdc++ . Options: arrow:shared-True
You are depending on 'protobuf/3.9.1.0' but it is not in the repository

Croydon · 2020-03-25T00:20:28Z

madebr creates pull request which depends on 4 other open pull requests

You are on fire 🔥 😄

recipes/arrow/all/conanfile.py

…MSVC library name

Co-Authored-By: Uilian Ries <uilianries@gmail.com>

conan-center-bot · 2020-04-26T00:56:32Z

Some configurations of 'arrow/0.17.0' failed in build 4 (76a22dcac4f07dd315c3df10e37c767aa0b73b15):

Linux x86_64, Release, gcc 5, libstdc++ . Options: arrow:shared-True
Access to all the logs

conan-center-bot · 2020-04-27T18:02:07Z

Some configurations of 'arrow/0.17.0' failed in build 6 (0e279be7d8035203268dc7068b3576800c28cc1b):

Linux x86_64, Release, gcc 5, libstdc++ . Options: arrow:shared-True
Access to all the logs

conan-center-bot · 2020-04-27T18:22:01Z

Some configurations of 'arrow/0.17.0' failed in build 7 (6e53ea6d6c51898c364f9f973cb860a5597e86d0):

Windows x86_64, Debug, Visual Studio 15, MDd. Options: arrow:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MTd. Options: arrow:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MD. Options: arrow:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MT. Options: arrow:shared-False
Access to all the logs

conan-center-bot · 2020-05-04T15:34:09Z

Some configurations of 'arrow/0.17.0' failed in build 8 (e45e5fbbdb9976789a242df83d8c4e540ba0683f):

Linux x86_64, Release, gcc 5, libstdc++ . Options: arrow:shared-False
Access to all the logs

conan-center-bot · 2020-05-04T15:50:45Z

Some configurations of 'arrow/0.17.0' failed in build 9 (cd7da504031ef8db47c25ee48dbfbf51d19e2fad):

Windows x86_64, Debug, Visual Studio 15, MTd. Options: arrow:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MDd. Options: arrow:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MD. Options: arrow:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MT. Options: arrow:shared-False
Access to all the logs

Croydon · 2020-05-05T08:33:41Z

Please put Fixed #63 to PR, thanks!

conan-center-bot · 2020-05-05T12:55:44Z

Some configurations of 'arrow/0.17.0' failed in build 10 (cd7da504031ef8db47c25ee48dbfbf51d19e2fad):

Windows x86_64, Debug, Visual Studio 15, MDd. Options: arrow:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MTd. Options: arrow:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MD. Options: arrow:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MT. Options: arrow:shared-False
Access to all the logs

conan-center-bot · 2020-08-03T08:37:29Z

Some configurations of 'arrow/1.0.0' failed in build 12 (993773af5915d0ebf8661f104bd8f0a0447e6559):

Linux x86_64, Debug, clang 3.9, libstdc++ . Options: arrow:shared-True
Access to all the logs
Linux x86_64, Debug, clang 3.9, libstdc++ . Options: arrow:shared-False
Access to all the logs
Linux x86_64, Debug, clang 3.9, libc++ . Options: arrow:shared-True
Access to all the logs
Linux x86_64, Debug, clang 3.9, libc++ . Options: arrow:shared-False
Access to all the logs

conan-center-bot · 2020-08-13T00:08:03Z

Some configurations of 'arrow/1.0.0' failed in build 13 (98b36479e5155a244a42aa05d6fe8b7dc5605cae):

Linux x86_64, Release, gcc 5, libstdc++ . Options: arrow:shared-True
- Hooks errors detected:
  - [HOOK - conan-center.py] pre_export(): ERROR: [CMAKE VERSION REQUIRED (KB-H048)] The test_packages/CMakeLists.txt requires CMake 3.1 at least. Update to 'cmake_minimum_required(VERSION 3.1)'. (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H048)
- Log download
- Log error Download
- Profile
Access to all the logs

conan-center-bot · 2020-08-13T00:35:45Z

Some configurations of 'arrow/1.0.0' failed in build 14 (f813f1d5b29973271fb85cfc645a770a49a09bfe):

Linux x86_64, Debug, clang 3.9, libstdc++ . Options: arrow:shared-True
Access to all the logs
Linux x86_64, Debug, clang 3.9, libstdc++ . Options: arrow:shared-False
Access to all the logs
Linux x86_64, Debug, clang 3.9, libc++ . Options: arrow:shared-True
Access to all the logs
Linux x86_64, Debug, clang 3.9, libc++ . Options: arrow:shared-False
Access to all the logs

htfy96 · 2020-08-13T03:53:11Z

Hi, thanks for your contribution on adding this recipe! Just several suggestions:

conda-forge already had an arrow-cpp recipe at https://github.com/conda-forge/arrow-cpp-feedstock/blob/68f4020a23e13039cab49927b6e9e51f27fc33ab/recipe/meta.yaml
Arrow supports modular builds for some of its components. I was wondering if it's possible to break this into four libraries (arrow, parquet, gandiva and plasma)
libparquet.so isn't included in current recipe. Maybe we can add it if options.with_parquet == True?

madebr · 2020-08-13T20:02:30Z

2. Arrow supports [modular builds for some of its components](https://github.com/apache/arrow/blob/master/docs/source/developers/cpp/building.rst#modular-build-targets). I was wondering if it's possible to break this into four libraries (arrow, parquet, gandiva and plasma)

I reviewed the options and added these as options and as a component.
Only arrow and plasma can be built atm, because of missing dependencies of parquet and gandiva.

conan-center-bot · 2020-08-13T20:17:41Z

An unexpected error happened and has been reported. Help is on its way! 🏇

conan-center-bot · 2020-08-13T20:43:25Z

Some configurations of 'arrow/1.0.0' failed in build 16 (b8d9a12f792c3c4875c949f0ea86da381f9b684e):

Linux x86_64, Debug, clang 3.9, libstdc++ . Options: arrow:shared-True
Access to all the logs
Linux x86_64, Debug, clang 3.9, libstdc++ . Options: arrow:shared-False
Access to all the logs
Linux x86_64, Debug, clang 3.9, libc++ . Options: arrow:shared-True
Access to all the logs
Linux x86_64, Debug, clang 3.9, libc++ . Options: arrow:shared-False
Access to all the logs

conan-center-bot · 2020-08-13T22:46:05Z

All green in build 17 (b7e73303baab49fc0389ff8308b150a108bc8280)! 😊

arrow/1.0.0: Generated 122 packages. All logs here

uilianries

Great Job!

SSE4

so many options - impresive!

Croydon · 2020-08-17T17:27:46Z

Nit: Please update PR title to reflect that 1.0.0 gets added not 0.16.0

conan-center-bot · 2020-08-17T17:33:50Z

All green in build 18 (b7e73303baab49fc0389ff8308b150a108bc8280)! 😊

arrow/1.0.0: Generated 122 packages. All logs here

SpaceIm · 2020-08-18T10:25:07Z

recipes/arrow/all/conanfile.py

+
+    def package_info(self):
+        self.cpp_info.components["libarrow"].libs = [self._lib_name("arrow")]
+        self.cpp_info.components["libarrow"].filenames["cmake_find_package"] = "Arrow"


too late to review, but does it create one config file per component?

I just checked, it creates FindArrow.cmake, FindPlasma.cmake, FindParquet.cmake .. config files with a lower case arrow/plasma/parquet target (or arrow_static/plasma_static/parquet_static if built statically).

CMake generators create only one file: FindArrow.cmake that provide the three targets, PkgConfig generator creates three files that follow the names of the components: arrow.pc, plasma.pc and parquet.pc.

Check PR here, there are some issues in the recipe: #2592

Add arrow/0.16.0 recipe

8e723f5

arrow: disable with_backtrace option by default

f229090

conan-center-bot added the Failed label Mar 25, 2020

uilianries requested changes Mar 25, 2020

View reviewed changes

recipes/arrow/all/conanfile.py Outdated Show resolved Hide resolved

SpaceIm mentioned this pull request Apr 3, 2020

[request] some of most relevant c++ libraries in github (by number of stars) #621

Open

madebr and others added 2 commits April 26, 2020 02:47

arrow: bump to version 0.17.0 + bump openssl dependency + fix static …

e383fd4

…MSVC library name

arrow: do not set build_type in configure()

76a22dc

Co-Authored-By: Uilian Ries <uilianries@gmail.com>

madebr added 2 commits April 27, 2020 19:44

arrow: bump protobuf + jemalloc is optional now + check jemalloc options

d131d49

arrow: enable_cxx is only required on a static jemalloc

0e279be

jemalloc: check shared status of jemalloc dependency

6e53ea6

arrow: pass cmake ARROW_USE_STATIC_CRT definition

e45e5fb

arrow: compiler.runtime is only available for Visual Studio

cd7da50

madebr added 2 commits July 31, 2020 20:34

arrow: update to arrow/1.0.0

0af78cb

arrow: fix jemalloc use

993773a

arrow: add no -Werror when building Debug

98b3647

arrow: bump required cmake version

f813f1d

arrow: add component support

d1c8ca3

arrow: thrift is available on cci

b8d9a12

conan-center-bot added the Unexpected Error label Aug 13, 2020

arrow: don't build on clang <= 3.9

b7e7330

conan-center-bot removed Unexpected Error Failed labels Aug 13, 2020

uilianries approved these changes Aug 14, 2020

View reviewed changes

uilianries requested review from danimtb, jgsogo and SSE4 August 14, 2020 21:23

jgsogo approved these changes Aug 17, 2020

View reviewed changes

SSE4 approved these changes Aug 17, 2020

View reviewed changes

madebr changed the title ~~Add arrow/0.16.0 recipe~~ Add arrow/1.0.0 recipe Aug 17, 2020

danimtb approved these changes Aug 18, 2020

View reviewed changes

danimtb merged commit d6c56be into conan-io:master Aug 18, 2020

madebr deleted the arrow_recipe branch August 18, 2020 09:22

SpaceIm reviewed Aug 18, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add arrow/1.0.0 recipe #1182

Add arrow/1.0.0 recipe #1182

madebr commented Mar 24, 2020 •

edited

Loading

conan-center-bot commented Mar 24, 2020

conan-center-bot commented Mar 25, 2020

Croydon commented Mar 25, 2020

conan-center-bot commented Apr 26, 2020

conan-center-bot commented Apr 27, 2020

conan-center-bot commented Apr 27, 2020

conan-center-bot commented May 4, 2020

conan-center-bot commented May 4, 2020

Croydon commented May 5, 2020

conan-center-bot commented May 5, 2020

conan-center-bot commented Aug 3, 2020

conan-center-bot commented Aug 13, 2020

conan-center-bot commented Aug 13, 2020

htfy96 commented Aug 13, 2020

madebr commented Aug 13, 2020

conan-center-bot commented Aug 13, 2020

conan-center-bot commented Aug 13, 2020

conan-center-bot commented Aug 13, 2020

uilianries left a comment

SSE4 left a comment

Croydon commented Aug 17, 2020

conan-center-bot commented Aug 17, 2020

SpaceIm Aug 18, 2020

madebr Aug 18, 2020

jgsogo Aug 18, 2020

Add arrow/1.0.0 recipe #1182

Add arrow/1.0.0 recipe #1182

Conversation

madebr commented Mar 24, 2020 • edited Loading

conan-center-bot commented Mar 24, 2020

conan-center-bot commented Mar 25, 2020

Croydon commented Mar 25, 2020

conan-center-bot commented Apr 26, 2020

conan-center-bot commented Apr 27, 2020

conan-center-bot commented Apr 27, 2020

conan-center-bot commented May 4, 2020

conan-center-bot commented May 4, 2020

Croydon commented May 5, 2020

conan-center-bot commented May 5, 2020

conan-center-bot commented Aug 3, 2020

conan-center-bot commented Aug 13, 2020

conan-center-bot commented Aug 13, 2020

htfy96 commented Aug 13, 2020

madebr commented Aug 13, 2020

conan-center-bot commented Aug 13, 2020

conan-center-bot commented Aug 13, 2020

conan-center-bot commented Aug 13, 2020

uilianries left a comment

Choose a reason for hiding this comment

SSE4 left a comment

Choose a reason for hiding this comment

Croydon commented Aug 17, 2020

conan-center-bot commented Aug 17, 2020

SpaceIm Aug 18, 2020

Choose a reason for hiding this comment

madebr Aug 18, 2020

Choose a reason for hiding this comment

jgsogo Aug 18, 2020

Choose a reason for hiding this comment

madebr commented Mar 24, 2020 •

edited

Loading