Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glog: fix cmake_find_package{,_multi} names #1181

Merged
merged 1 commit into from
Mar 25, 2020

Conversation

madebr
Copy link
Contributor

@madebr madebr commented Mar 24, 2020

Specify library name and version: glog/0.4.0

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@madebr madebr mentioned this pull request Mar 24, 2020
4 tasks
@conan-center-bot
Copy link
Collaborator

All green in build 1 (fc01f76f3b66c9c088467df314367c929c4b298f)! 😊

@SSE4 SSE4 requested a review from uilianries March 25, 2020 08:26
@danimtb danimtb self-assigned this Mar 25, 2020
@danimtb danimtb merged commit d681a63 into conan-io:master Mar 25, 2020
@madebr madebr deleted the glog_name branch March 28, 2020 00:32
@SpaceIm
Copy link
Contributor

SpaceIm commented Aug 4, 2020

#2363 (comment)

@madebr Where did you find these names?

In glog master branch:

I don't see any official module file for glog.

@madebr
Copy link
Contributor Author

madebr commented Aug 4, 2020

@SpaceIm
Indeed, I was wrong.
I just checked google for cmake find glob and combinations with find and config.
Thanks for rectifying.

@madebr
Copy link
Contributor Author

madebr commented Aug 4, 2020

This might mean that some dependency on glog will break.
I don't know remember which one exactly it was..

@SpaceIm
Copy link
Contributor

SpaceIm commented Aug 4, 2020

There are only 2 recipes depending on glog in CCI: folly and ceres-solver

@madebr
Copy link
Contributor Author

madebr commented Aug 4, 2020

Thanks, then I'll have to search in projects.

@SpaceIm
Copy link
Contributor

SpaceIm commented Aug 4, 2020

folly recipe works fine if lowercase cmake name is restored (this why I came here :p #2363 (comment)). Didn't check ceres-solver with glog enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants